Bug #555 CONFIG_SMP redifined
Submitted: 31 May 2003 8:50 Modified: 3 Jul 2003 3:33
Reporter: Jens Elkner
Status: Closed
Category:Server: Compiling Severity:S3 (Non-critical)
Version:4.0.13 OS:Linux (Linux 2.4.20)
Assigned to: Sinisa Milivojevic Target Version:

[31 May 2003 8:50] Jens Elkner 
Description:
include/my_global.h does not check, wether CONFIG_SMP is already defined.
Thus hundreds of warning messages are logged, which makes it hard, to
see any other problems, when compiling mysql.

How to repeat:
E.g.: Use a machine with an SMP enabled kernel.

Suggested fix:
--- mysql-4.0.13/include/my_global.h.orig	Fri May 16 13:47:09 2003
+++ mysql-4.0.13/include/my_global.h	Fri May 30 16:24:14 2003
@@ -263,8 +263,10 @@
 #endif
 #ifdef HAVE_ATOMIC_ADD
 #define __SMP__
-#define CONFIG_SMP
 #include <asm/atomic.h>
+#ifndef CONFIG_SMP
+#define CONFIG_SMP
+#endif
 #endif
 #include <errno.h>				/* Recommended by debian */
 /* We need the following to go around a problem with openssl on solaris */
[31 May 2003 8:58] Sinisa Milivojevic 
Thank you for your patch.

It has been applied in the current source tree.
[4 Jun 2003 11:47] Lenz Grimmer 
Set Status to "Patch pending" and re-assign to Sinisa until the patch has actually been
pushed into 
the BK tree.
[3 Jul 2003 3:33] Michael Widenius 
Fix will be in 4.0.14