Bug #55087 Performance schema: optimization of the instrumentation interface

• Submitted: 8 Jul 2010 15:38
• Modified: 29 Jul 2010 18:44
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Performance Schema
• Severity: S5 (Performance)
• OS: Any
• Assigned to: Marc ALFF
• CPU Architecture: Any

[8 Jul 2010 15:38] Marc ALFF

Description:
This is a performance bug.

Implement interface changes in include/mysql/psi to improve runtime performances,
as identified by internal benchmarks and prototyping.

How to repeat:
See mysql-next-mr-perfschema

Suggested fix:
- locker state to provide memory on the stack
- simplify unlock() api calls

[9 Jul 2010 22:00] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113280

3103 Marc Alff	2010-07-09
      Bug#55087 Performance schema: optimization of the instrumentation interface
      
      This change is for performance optimization.
      
      Fixed the performance schema instrumentation interface as follows:
      - simplified mysql_unlock_mutex()
      - simplified mysql_unlock_rwlock()
      - simplified mysql_cond_signal()
      - simplified mysql_cond_broadcast()
      
      Changed the get_thread_XXX_locker apis to have one extra parameter,
      to provide memory to the instrumentation implementation.
      This API change allows to use memory provided by the caller,
      to avoid having to use thread local storage.
      Using this extra parameter will be done in a separate fix,
      this change is for the interface only.
      
      Adjusted all the code and unit tests accordingly.

[12 Jul 2010 19:30] Christopher Powers

Reviewed patch. Changes ok pending review from Jimmy Yang.

[14 Jul 2010 14:20] Jimmy Yang

Reviewed InnoDB related file changes. Changes look fine.

[14 Jul 2010 15:37] Marc ALFF

Pushed into:
- mysql-trunk-bugfixing (5.5)
- mysql-next-mr-bugfixing (5.6)

[23 Jul 2010 12:24] Bugs System

Pushed into mysql-trunk 5.5.6-m3 (revid:[e-mail]-20100723121820-jryu2fuw3pc53q9w) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)

[23 Jul 2010 12:31] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100723121929-90e9zemk3jkr2ocy) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (pib:18)

[29 Jul 2010 18:44] Paul DuBois

Noted in 5.5.6 changelog.

Overhead for the Performance Schema interface was reduced.