Bug #51434 ndb_restore should error if hashmap creation fails

Description:
In consumer_restore.cpp:

    if (m_restore_meta)
    {
      int ret = dict->createHashMap(old);
      if (ret == 0)
      {
        info << "Created hashmap: " << old.getName() << endl;
      }
    }

So if the hashmap creation failed execution would continue and the error condition will be lost.

How to repeat:
.

Suggested fix:
Add the following to the end of the 'if':

} else {
  NdbError errobj = dict->getNdbError();
  err << "Could not create HashMap \""<< old.getName() << "\": "
      << errobj << endl;
  return false;
}

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/101267

3428 Andrew Hutchings	2010-02-23
      Bug #51434  	ndb_restore should error if hashmap creation fails
      
      Now handles errors if hashmap creation fails (intentionally ignores schema exists).

Hi Andrew,

this patch is approved, do you need help to push it into a 7.0 version ?

/Jonas

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/107640

3526 Jonas Oreland	2010-05-06
      Bug #51434  ndb_restore should error if hashmap creation fails
            
            Now handles errors if hashmap creation fails (intentionally ignores schema exists).
      From Andrew Hutchings

pushed to 7.0.15 and 7.1.4

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/107645

3526 Martin Skold	2010-05-06 [merge]
      Merge
      modified:
        storage/ndb/include/kernel/signaldata/DictTabInfo.hpp
        storage/ndb/tools/restore/consumer_restore.cpp

Documented in the NDB-7.0.15 and 7.1.4 changelogs as follows:

      ndb_restore did not raise any errors if hashmap creation failed 
      during execution.

Closed.