MySQL Bugs: #50865: SQL Editor tabs with the same label

Bug #50865	SQL Editor tabs with the same label
Submitted:	3 Feb 2010 6:52	Modified:	16 Feb 2010 17:20
Reporter:	João Bruni	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench: SQL Editor	Severity:	S3 (Non-critical)
Version:	5.2.15 beta	OS:	Any (ubuntu 9.10, XP)
Assigned to:	Sergei Tkachenko	CPU Architecture:	Any
Tags:	tab labels

Description:
SQL Editor created two tabs with the same "Result 1" label.

It should have created "Result 1" and then "Result 2", right?

Please, see screenshot here:

http://jbruni.com.br/wb_sqleditor_tabs.png

How to repeat:
In the SQL Editor...

First, I executed a simple SELECT query by pressing CTRL + RETURN in the keyboard.

It created the first "Result 1" tab.

Next, I clicked in the "Explain selected SQL" button in the toolbar.

It created the second "Result 1" tab.

Suggested fix:
Instead of a second "Result 1" tab, the second tab should be labeled "Result 2".

Please, check how the SQL Editor tab labels are being assigned.

Thanks!

Thank you for the problem report. Verified just as described on Windows XP.

I have browsed source code and found related code at following files:

backend/wbprivate/sqlide/wb_sql_editor_form.h
backend/wbprivate/sqlide/wb_sql_editor_form.cpp

It seems that the "_rs_sequence" property should be the ResultSet counter.

At backend/wbprivate/sqlide/wb_sql_editor_form.cpp, lines #785 to $787, we can see the tab label (caption) assignment.

At backend/wbprivate/sqlide/wb_sql_editor_form.h, line #150, we can see the "_rs_sequence" property declaration.

Shouldn't it be declared "static"?

fixed in repository

Changelog for 5.2.16 updated. See Bug #50334.