Bug #50182 mtr: allow $MTR_PORT_BASE or --port-base= as alternative to MTR_BUILD_THREAD

Submitted: 8 Jan 2010 11:26 Modified: 17 Jun 2010 19:43
Reporter: Bjørn Munch Email Updates:
Status: Closed Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S4 (Feature request)
Version:5.1+ OS:Any
Assigned to: Bjørn Munch CPU Architecture:Any

[8 Jan 2010 11:26] Bjørn Munch
Description:
The use of $MTR_BUILD_THREAD or --build-thread to indirectly specify port base is confusing, both in name and values. It would better to call it $MTR_PORT_BASE and --port-base and have the value be the *actual* port number.

How to repeat:
N/A

Suggested fix:
To avoid having to rewrite all the internal management of this, the port base value could be converted back to the MTR_BUILD_THREAD value. This would mean it has to be a multiple of 10, or be rounded down. Ranges are allocated in blocks of 10 anyway.
[11 Jan 2010 9:58] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/96473

2876 Bjorn Munch	2010-01-11
      Bug #50182 mtr: allow $MTR_PORT_BASE or --port-base= as alternative to MTR_BUILD_THREAD
      As suggested, convert internally to value of build_thread
[25 Jan 2010 10:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/98028

2884 Bjorn Munch	2010-01-25
      Bug #50182 mtr: allow $MTR_PORT_BASE or --port-base= as alternative to MTR_BUILD_THREAD
       As suggested, convert internally to value of build_thread
[25 Jan 2010 12:47] Bjørn Munch
Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr
[20 Feb 2010 9:30] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100220092844-jh07ayojyxn8uh9p) (version source revid:bjorn.munch@sun.com-20100125123531-2dxmmczd9hfm4ye1) (merge vers: 6.0.14-alpha) (pib:16)
[20 Feb 2010 9:33] Bugs System
Pushed into 5.5.3-m2 (revid:alik@sun.com-20100220092622-wvhh1vfy5tjq4mhu) (version source revid:bjorn.munch@sun.com-20100125102422-uz803coqz5tqkhfz) (merge vers: 5.5.1-m2) (pib:16)
[20 Feb 2010 9:36] Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100220092730-paoo5t9gcajs5dq8) (version source revid:bjorn.munch@sun.com-20100125103031-em5g54dq400bi7sf) (pib:16)
[22 Feb 2010 20:19] Paul DuBois
Noted in 5.5.3, 6.0.14 changelogs.

mysql-test-run.pl has a new --portbase option and a corresponding
MTR_PORT_BASE environment variable for setting the port range, as an
alternative to the existing --build-thread option.

Setting report to Need Merge pending push to 5.1.x, Celosia.
[1 Mar 2010 8:43] Bugs System
Pushed into 5.1.45 (revid:joro@sun.com-20100301083827-xnimmrjg6bh33o1o) (version source revid:azundris@mysql.com-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)
[1 Mar 2010 16:32] Paul DuBois
Noted in 5.1.45 changelog.
[17 Jun 2010 12:19] Bugs System
Pushed into 5.1.47-ndb-7.0.16 (revid:martin.skold@mysql.com-20100617114014-bva0dy24yyd67697) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)
[17 Jun 2010 13:06] Bugs System
Pushed into 5.1.47-ndb-6.2.19 (revid:martin.skold@mysql.com-20100617115448-idrbic6gbki37h1c) (version source revid:martin.skold@mysql.com-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)
[17 Jun 2010 13:47] Bugs System
Pushed into 5.1.47-ndb-6.3.35 (revid:martin.skold@mysql.com-20100617114611-61aqbb52j752y116) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)

Portions of this website are copyright © 2001, 2002 The PHP Group

Page generated in 0.064 sec. using MySQL 8.4.7-u6-cloud

Timestamp references displayed by the system are UTC.
Content reproduced on this site is the property of the respective copyright holders.
It is not reviewed in advance by Oracle and does not necessarily represent the opinion of Oracle or any other party.