Bug #49790 If applying of modified stored procedure fails - code is rolled back quietly
Submitted: 18 Dec 2009 0:12 Modified: 22 Jan 2010 15:40
Reporter: Vasili Sviridov Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Workbench Severity:S2 (Serious)
Version:5.2.10 OSS Beta OS:Any
Assigned to: Sergei Tkachenko CPU Architecture:Any

[18 Dec 2009 0:12] Vasili Sviridov
Description:
There's a dedicated revert button, however the code is reverted to original on failure regardless, making you lose all changes. I think Ctrl+Z is able to undo the revert, and keep your changes. But this behaviour is very non-obvious.

How to repeat:
Open a working stored procedure
Apply changes
Add an error, so that procedure cannot be stored
Click Apply

After failure original code is back in the editor, all user-made changes are gone

Suggested fix:
Let the Revert button take care of it instead.
[18 Dec 2009 0:13] Vasili Sviridov
"Code", not "Core", typo!
[18 Dec 2009 9:30] Johannes Taxacher
same for views
[19 Jan 2010 14:31] Johannes Taxacher
fix confirmed. will be included in 5.2.13
[22 Jan 2010 15:40] Tony Bedford
An entry has been added to the 5.2.13 changelog:

In the SQL Editor, if a routine was edited, and the changes applied, then the changes were automatically reverted if the apply failed. This meant that any changes the user had made would need to be typed in again.