MySQL Bugs: #49345: re-introduce gprof to mysql-test-run.pl

Bug #49345	re-introduce gprof to mysql-test-run.pl
Submitted:	2 Dec 2009 12:43	Modified:	17 Jun 2010 19:38
Reporter:	Georgi Kodinov	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S3 (Non-critical)
Version:	v2	OS:	Any
Assigned to:	Bjørn Munch	CPU Architecture:	Any
Tags:	regression

Description:
mysql-test-run.pl v.1 had a command line option --gprof allowing it to do profiling on the server during a test run.
mtr v2 doesn't have it anymore.

How to repeat:
./mysql-test-run.pl --gprof <atest>

Suggested fix:
Please re-introduce this to mtr v.2 : it's very useful when you need it.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/93197

2866 Bjorn Munch	2009-12-08
      Bug #49345 re-introduce gprof to mysql-test-run.pl
      Was available in v1
      First stab at porting to v2, but don't quite grok the v1 implementation
      I think this produces the same result though.

I got a comment that the gprof output should be saved in a file rather than printed on stdout, as it's usually very large. I will look into that.

Please disregard previous comment, this patch already does save output to separate file!

A few things in gprof_collect() look odd:

1) print statement ("GPROF output ...") should be inside the if, only print if gmon.out exists

2) system() should be terminated with a ;, not ,

3) probably better to use > instead of >> (append is confusing, I think)

4) what is the # FIXME comment about?

Otherwise, the general patch seems OK.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/96035

2870 Bjorn Munch	2010-01-05
      Bug #49345 re-introduce gprof to mysql-test-run.pl
      Was available in v1
      Porting to v2 required some rewriting
      Updated after review comments

Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100220092844-jh07ayojyxn8uh9p) (version source revid:bjorn.munch@sun.com-20100106093632-yy2ts5rndk3cchvm) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into 5.5.3-m2 (revid:alik@sun.com-20100220092622-wvhh1vfy5tjq4mhu) (version source revid:bjorn.munch@sun.com-20100106085744-tr26s8escdaiu7ky) (merge vers: 5.5.1-m2) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100220092730-paoo5t9gcajs5dq8) (version source revid:bjorn.munch@sun.com-20100106090111-s6smcs0si1ohiiu5) (pib:16)

Noted in 5.5.3, 6.0.14 changelogs.

mysql-test-run.pl has a new --gprof option that runs the server
throuigh the gprof profiler, much the same way the currently
supported --gcov option runs it through gcov.

Setting report to Need Merge pending push to 5.1.x, Celosia.

Pushed into 5.1.45 (revid:joro@sun.com-20100301083827-xnimmrjg6bh33o1o) (version source revid:azundris@mysql.com-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)

Noted in 5.1.45 changelog.

Pushed into 5.1.47-ndb-7.0.16 (revid:martin.skold@mysql.com-20100617114014-bva0dy24yyd67697) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)

Pushed into 5.1.47-ndb-6.2.19 (revid:martin.skold@mysql.com-20100617115448-idrbic6gbki37h1c) (version source revid:martin.skold@mysql.com-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)

Pushed into 5.1.47-ndb-6.3.35 (revid:martin.skold@mysql.com-20100617114611-61aqbb52j752y116) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)