MySQL Bugs: #49284: Undo includes things which WB cannot (or does not) undo

Bug #49284	Undo includes things which WB cannot (or does not) undo
Submitted:	1 Dec 2009 17:55	Modified:	15 Jan 2010 14:14
Reporter:	Todd Farmer (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench	Severity:	S2 (Serious)
Version:	5.2 r4643	OS:	Windows (XP)
Assigned to:	Alfredo Kojima	CPU Architecture:	Any

Description:
WB has an undo/redo capability, of sorts, it seems.  But the implementation is hugely problematic:

1.  It adds tasks to the undo/redo log which it cannot, apparently undo
2.  There's no indication of what has successfully been "undone"
3.  The undo/redo events persist long after the associated context has been deleted.

For example, I added a new column and marked it as not-null.  I applied the changes, so this is saved.  Now, in my undo list, I see, "Undo set 'v1.test' NOT NULL".  I push this, but of course v1.test still has NOT NULL set.  And now I have the option to redo it, plus the option to "Undo Add column 'v1.test'".  Of course, undoing that also has no impact.

Furthermore, after I close the SQL Editor (leaving only the home page up), I continue to have these undo/redo options enabled.

How to repeat:
See above.

Suggested fix:
If WB cannot undo it, don't add it to the undo/redo list.

Is this bug about the Live table editor (as opposed to the model) editor?
If so, Undo should probably be totally disabled in these editors.

Undo is not tracked anymore for live editors.

fix confirmed. will be included in 5.2.12

A 'change' entry has been added to the 5.2.12 changelog:

Undo operations are no longer tracked in the editors that work with live databases, such as table editors within the SQL Editor.