MySQL Bugs: #49179: EDIT table data loses data.

Bug #49179	EDIT table data loses data.
Submitted:	28 Nov 2009 18:11	Modified:	15 Jan 2010 13:44
Reporter:	Edward Rudd	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench	Severity:	S2 (Serious)
Version:	5.2.8	OS:	MacOS
Assigned to:	Alfredo Kojima	CPU Architecture:	Any

Description:
I have a table like this

CREATE TABLE `document_types` (
  `document_type_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `base_document_type_id` int(10) unsigned DEFAULT NULL,
  `name` varchar(45) NOT NULL,
  `flags` set('abstract') NOT NULL,
  `url_prefix` varchar(45) DEFAULT NULL,
  PRIMARY KEY (`document_type_id`),
  KEY `fk_document_types_document_types` (`base_document_type_id`),
  CONSTRAINT `fk_document_types_document_types` FOREIGN KEY (`base_document_type_id`) REFERENCES `document_types` (`document_type_id`)
) ENGINE=InnoDB AUTO_INCREMENT=4 DEFAULT CHARSET=utf8 

And when I try to "EDIT data" in Workbench 5.2.8 and enter new data (specifically just entering a name and a url_prefix) then click the check to apply nothing gets inserted into the table.

If I manually run an insert statement in workbench filing just those 2 columns it works fine.

When I edit the table again and add a second row and update the row I "Inserted" it deletes the row that existed and doesn't add the new one.

This makes the "editing" feature completely unreliable and unusable compared to the Query browser where this would work fine.

I am connecting to a mysql 5.1.40 server (packaged with Zend Server CE 4.0.6)

How to repeat:
1) create the table
2) "edit" the table (SQL "EDIT document_types")
3) set the columns
4) click the "save/apply" button
5) refresh the display

WOAH!!..  Apparently ANY time I edit and apply changes it removed ALL records from the table.

still true for 5.2.9 (internal build).
problem seems to be wrong feedback from WB. 
By entering data in the example table (as specified by reporter) only for columns `name` and `url_prefix`, the insert should fail, as the `flags` column is defined as NOT NULL. Hitting the apply checkmark to send/commit the data to database) WB reports: "changes applied" - on subsequent actions, WB answers reports "there are pending changes, please commit or rollback first" while it should have reported the unsuccessfull insert in first place.

WB inserts data correctly, when I enter a row by just supplying values for columns `name` and `flags`. (as a workaround)

Following changes were made:
- if an error occurs during change apply, a dialog showing the errors will pop up
- instead of status text saying "Changes Applied" it will show "Apply failed"

In addition, the following changes are proposed:
- remove textbox from Linux and Windows implementation too and change them to popup dlg
- make messages from recordset Apply be also directed to the Output tab, where they belong

(please remind when this bug gets reviewed)

Fixed apply after failure

this has been fixed. will be included in 5.2.12

An entry has been added to the 5.2.12 changelog:

In the SQL Editor if an EDIT table operation was being carried out, it appeared that data in the table was not updated, and also a row already inserted would be erroneously deleted when attempting to add a new row of data, when changes were applied.

MySQL Workbench has been changed so that if an error occurs during changes being applied, an error dialog is displayed showing any errors that occurred. Also, the status text is now updated to say “Apply Failed”, rather than “Changes Applied”.