Bug #47493 Backup logs cannot be flushed with mysqladmin
Submitted: 21 Sep 20:40 Modified: 28 Oct 11:11
Reporter: Chuck Bell
Status: Patch queued
Category:Server: Backup Severity:S3 (Non-critical)
Version:5.4.4 OS:Any
Assigned to: Ritheesh Vedire Target Version:
Triage: Triaged: D3 (Medium)

[21 Sep 20:40] Chuck Bell
Description:
The mysqladmin program has commands that correspond to a number of FLUSH options:

mysqladmin --help:

...
  flush-hosts           Flush all cached hosts
  flush-logs            Flush all logs
  flush-status        Clear status variables
  flush-tables          Flush all tables
  flush-threads         Flush the thread cache
  flush-privileges      Reload grant tables (same as reload)
...

But there isn't a flush-backup-logs command. There should be an option to flush the
backup logs from the mysqladmin tool.

How to repeat:
mysqladmin --help

Suggested fix:
Add the feature to the mysqladmin application.
[21 Sep 21:45] Sveta Smirnova
Thank you for the report.

Verified as described.
[20 Oct 11:47] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87439

2879 Ritheesh Vedire	2009-10-20
      BUG#47493: Add 'flush backup logs' feature to mysqladmin 
     @ client/mysqladmin.cc
        Added the feature.  I have no idea how to write a test script for it.
[21 Oct 14:27] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87631

2880 Ritheesh Vedire	2009-10-21
      BUG#47493:  Add 'flush-backup-logs' to mysqladmin
     @ client/mysqladmin.cc
        used already existing sql command  'flush backup logs' .
[21 Oct 16:17] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87660

2880 Ritheesh Vedire	2009-10-21
      BUG#47493: add 'flush-backup-logs'  feature to mysqladmin
     @ client/mysqladmin.cc
        Used the existing SQL command 'flush backup logs'.
     @ mysql-test/suite/backup/t/backup_logs_output.test
        Irrespective of log_backup_output options log files are created.
        So I have tested  only for TABLE,FILE option. 
        The command doesn't return anything when it succeeds.
[21 Oct 16:51] Rafal Somla
Approved pending changes.
[26 Oct 10:17] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/88116

2884 Ritheesh Vedire	2009-10-26
      BUG#47493: Backup logs cannot be flushed with mysqladmin.
     @ client/mysqladmin.cc
         Used the existing SQL command 'flush backup logs'.
         Changed the code format.
     @ mysql-test/suite/backup/t/backup_logs_output.test
         Irrespective of log_backup_output options log files are created.
         So I have tested  only for TABLE,FILE option. 
         The command doesn't return anything when it succeeds.
[27 Oct 16:13] Chuck Bell
Patch approved under condition that a new bug report will be opened that addresses the
following issues:

* The existing test case for flush backup logs is insufficient
* The purge backup logs command should be part of mysqladmin