Bug #47166 stringmemory default is wrong in docs (MYSQL CLUSTER)

• Submitted: 7 Sep 2009 10:07
• Modified: 9 Sep 2009 15:30
• Reporter: Johan Andersson
• Status: Closed
• Category: MySQL Cluster: Cluster (NDB) storage engine
• Severity: S3 (Non-critical)
• Version: 5.1+ (?)
• OS: Any
• Assigned to: Jonas Oreland
• CPU Architecture: Any
• Tags: cluster, StringMemory

[7 Sep 2009 10:07] Johan Andersson

Description:
The following is in the manual:

StringMemory
Restart Type 	system
Permitted Values (>= 5.1.0) 	
Type 	numeric
Default 	5

but the default is 25 now.

How to repeat:
-

Suggested fix:
-

[7 Sep 2009 12:12] Sveta Smirnova

Thank you for the report.

Verified as described:

$vim storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp
...
  ndb_mgm_get_int_parameter(p, CFG_DB_STRING_MEMORY, &sm);
  if (sm == 0)
    sm = 25;
...

[8 Sep 2009 12:12] Jon Stephens

The info in the Manual comes from ndb/src/mgmsrv/ConfigInfo.cpp, which is where this should be set (like other parameters):

  { 
    CFG_DB_STRING_MEMORY,
    "StringMemory",
    DB_TOKEN,
    "Default size of string memory (0 -> 5% of max 1-100 -> %of max, >100 -> actual bytes)",
    ConfigInfo::CI_USED,
    false,
    ConfigInfo::CI_INT,
    "0",
    "0",
    STR_VALUE(MAX_INT_RNIL) },

Unless there's some critical reason why this can't be done, ConfigInfo.cpp should be fixed.

[9 Sep 2009 9:00] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/82780

2991 Jonas Oreland	2009-09-09
      ndb - bug#47166
        Fix correct default value of StringMemory (25) in ConfigInfo
          to avoid confusion

[9 Sep 2009 9:02] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/82781

2991 Jonas Oreland	2009-09-09
      ndb - bug#47166
        Fix correct default value of StringMemory (25) in ConfigInfo
        to avoid confusion

[9 Sep 2009 11:04] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090909110427-4vsmv05b2i6svff9) (version source revid:[e-mail]-20090909110427-4vsmv05b2i6svff9) (merge vers: 5.1.35-ndb-7.1.0) (pib:11)

[9 Sep 2009 11:05] Bugs System

Pushed into 5.1.37-ndb-6.2.19 (revid:[e-mail]-20090909090145-msrb48cjw8yjv5oc) (version source revid:[e-mail]-20090909090145-msrb48cjw8yjv5oc) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

[9 Sep 2009 11:05] Bugs System

Pushed into 5.1.37-ndb-6.3.27 (revid:[e-mail]-20090909090834-znkdnl02929etrky) (version source revid:[e-mail]-20090909090834-znkdnl02929etrky) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

[9 Sep 2009 11:06] Bugs System

Pushed into 5.1.37-ndb-7.0.8 (revid:[e-mail]-20090909110150-kdvot0410na89hk5) (version source revid:[e-mail]-20090909091751-4somugxyxyue3gzo) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[9 Sep 2009 15:30] Jon Stephens

Documented bugfix in the NDB-6.2.19, 6.3.27, and 7.0.8 changelogs, as follows:

        The default value for the StringMemory configuration parameter, 
        unlike other configuration parameters, was not set in
        ndb/src/mgmsrv/ConfigInfo.cpp.

Also updated StringMemory default value info in the documentation per Johan's original request.

Closed.