Bug #46891 ndb_config outputs not well-formed XML

• Submitted: 24 Aug 2009 12:35
• Modified: 25 Aug 2009 12:01
• Reporter: Jon Stephens
• Status: Closed
• Category: MySQL Cluster: Cluster (NDB) storage engine
• Severity: S2 (Serious)
• Version: telco-7.0+
• OS: Any
• Assigned to: Jon Stephens
• CPU Architecture: Any

[24 Aug 2009 12:35] Jon Stephens

Description:
XML output contains quotes within quoted attribute values, making it invalid.

How to repeat:
Do ndb_config --configinfo --xml then try to validate the resulting output.

Suggested fix:
Remove inline '\"' sequences from parameter descriptions in ConfigInfo.cpp.

[24 Aug 2009 12:35] Jon Stephens

Patch already approved by email (Magnus); filing bug because I also need to test bug status auto-update (Jonas).

[24 Aug 2009 12:44] Jon Stephens

Corrected version -- bug exists in 7.0+ only.

[24 Aug 2009 13:13] Bugs System

Pushed into 5.1.35-ndb-7.0.7 (revid:[e-mail]-20090824131036-jwi8xo432yyakay9) (version source revid:[e-mail]-20090824131036-jwi8xo432yyakay9) (merge vers: 5.1.35-ndb-7.0.7) (pib:11)

[24 Aug 2009 13:22] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090824131942-ev8x2upwltalh8ou) (version source revid:[e-mail]-20090824131942-ev8x2upwltalh8ou) (merge vers: 5.1.35-ndb-7.1.0) (pib:11)

[24 Aug 2009 13:31] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090824133056-75vbrvgctw7arlo3) (version source revid:[e-mail]-20090824133056-75vbrvgctw7arlo3) (merge vers: 5.1.35-ndb-7.1.0) (pib:11)

[24 Aug 2009 13:32] Jon Stephens

Here's the patch, since it apparently didn't make it to the Commits list:

=== modified file 'storage/ndb/src/mgmsrv/ConfigInfo.cpp'
--- storage/ndb/src/mgmsrv/ConfigInfo.cpp       2009-07-03 06:34:01 +0000
+++ storage/ndb/src/mgmsrv/ConfigInfo.cpp       2009-07-30 09:41:21 +0000
@@ -1241,7 +1241,7 @@
     CFG_DB_ARBIT_METHOD,
     "Arbitration",
     DB_TOKEN,
-    "How to perform arbitration to avoid \"split brain\" when node(s) fail",
+    "How to perform arbitration to avoid split-brain issue when node(s) fail",
     ConfigInfo::CI_USED,
     false,
     ConfigInfo::CI_ENUM,
@@ -1680,7 +1680,7 @@
     CFG_NDBMT_CLASSIC,
     "__ndbmt_classic",
     DB_TOKEN,
-    "For ndbmtd use \"mt-classic\"",
+    "For ndbmtd use mt-classic",
     ConfigInfo::CI_USED,
     false,
     ConfigInfo::CI_BOOL,

[25 Aug 2009 12:01] Jon Stephens

Documented bugfix in the NDB-7.0.7 changelog as follows:

      The output from ndb_config --configinfo --xml contained quote 
      characters (") within quoted XML attributes, causing it not to 
      be well-formed.