| Bug #46541 | Use other option than --new for backup | ||
|---|---|---|---|
| Submitted: | 4 Aug 2009 12:13 | Modified: | 17 Sep 2009 23:39 |
| Reporter: | Lars Thalmann | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Backup | Severity: | S3 (Non-critical) |
| Version: | 5.4.4 | OS: | Any |
| Assigned to: | Chuck Bell | CPU Architecture: | Any |
[4 Aug 2009 12:13]
Lars Thalmann
[4 Aug 2009 21:33]
Chuck Bell
Chuck steals the bug. ;) I opted for --mysql-backup (bool) as Paul suggested. Thanks, Paul! Initial patch created. Just need to run tests and commit.
[5 Aug 2009 15:13]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80177 2854 Chuck Bell 2009-08-05 BUG#46541 : Use other option than --new for backup The --new option is overused. We need a new option specifically for backup. This patch introduces the bool option --mysql-backup. Use --mysql-backup (or --mysql-backup=1) to enable backup on server startup or --mysql-backup=0 to disable it. The option is disabled (--mysql-backup=0) by default. @ mysql-test/r/backup_disabled.result Corrected error message in result file. @ mysql-test/suite/backup/my.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/backup_engines/my.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/backup_extra/my.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/backup_ptr/my.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/ndb/t/backup_no_ndb.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup_block.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup_extra.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup_multi.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup_ptr.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/suite/rpl/t/rpl_backup_shutdown.cnf Changed --new to --mysql-backup in configuration. @ mysql-test/t/backup_disabled.test Changed --new to --mysql-backup in test. @ sql/mysql_priv.h Added external definition for opt_mysql-backup. @ sql/mysqld.cc Added bool opt_mysql_backup for internal storage of option. Added OPT_MYSQL_BACKUP enum. Added code to detect --mysql-backup on startup and to set opt_mysql_backup accordingly. @ sql/share/errmsg-utf8.txt Changed error message from stating needed --new to need --mysql-backup. @ sql/share/errmsg.txt Changed error message from stating needed --new to need --mysql-backup. @ sql/sql_parse.cc Changed detection of --new to opt_mysql-backup for disabling or enabling mysql backup.
[6 Aug 2009 5:26]
Rafal Somla
Good to push.
[6 Aug 2009 12:56]
Jørgen Løland
Good to push.
[6 Aug 2009 17:57]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80317 2855 Chuck Bell 2009-08-06 [merge] Local merge prior to push BUG#46541.
[6 Aug 2009 18:17]
Chuck Bell
Patch queued.
[28 Aug 2009 10:01]
Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090828100112-r73xkx8dhekz5bbb) (version source revid:jorgen.loland@sun.com-20090818084812-rlq2mh37241doswu) (merge vers: 5.4.4-alpha) (pib:11)
[17 Sep 2009 23:39]
Paul DuBois
No changelog entry needed. Not in any released version.
[7 Dec 2009 18:26]
Paul DuBois
Noted in 6.0.14 changelog. A new option, --mysql-backup, determines whether MySQL Backup is enabled or disabled. By default, MySQL Backup is disabled.
