MySQL Bugs: #46535: Feature request: improve U0166 Heat chart rule error messages

Bug #46535	Feature request: improve U0166 Heat chart rule error messages
Submitted:	3 Aug 2009 22:49	Modified:	19 Nov 2009 10:57
Reporter:	Roel Van de Paar	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Advisors/Rules	Severity:	S4 (Feature request)
Version:		OS:	Any
Assigned to:	Sloan Childers	CPU Architecture:	Any

Description:
Stems from: http://bugs.mysql.com/bug.php?id=42932

As discussed with Sloan:

* sloan makes a mental note to add some more verbosity to that error message so that 2.1 has more information about "why" it may not be unscheduled
<Roel> we may get more of these I think
<sloan> even better... if you think so then please open me a feature request

How to repeat:
N/A

Suggested fix:
List of error messages to add more verbosity:
U0166 Heat chart rule "MySQL Agent Not Communicating With Database Server" scheduled against "<server-name>" may not be disabled". 
U0166 Heat chart rule "MySQL Agent Not Reachable" scheduled against "<server-name>" may not be disabled". 
U0166 Heat chart rule "MySQL Server Not Reachable" scheduled against "<server-name>" may not be disabled". 
U0166 Heat chart rule "MySQL Agent Not Communicating With Database Server" scheduled against "<server-name>" may not be unscheduled". 
U0166 Heat chart rule "MySQL Agent Not Reachable" scheduled against "<server-name>" may not be unscheduled". 
U0166 Heat chart rule "MySQL Server Not Reachable" scheduled against "<server-name>" may not be unscheduled".

Sloan Childers writes: 
patch pushed to etools/branches/2.1 and etools/trunk (2.2)

Keith Russell writes: 
Patch installed in versions => 2.1.1.1100.

Marcos Palacios writes: 
Tested in service manager build 2.1.1.1100. Almost fixed, but there is a problem with 'disable'. See below.

Messages now look like this for 'unschedule':

    * U0165 Heat chart rule "MySQL Agent Not Communicating With Database Server" scheduled against "BUILD-WIN32:3306" may not be unscheduled. This rule is required for the product to function properly.
    * U0165 Heat chart rule "MySQL Agent Not Reachable" scheduled against "BUILD-WIN32:3306" may not be unscheduled. This rule is required for the product to function properly.
    * U0165 Heat chart rule "MySQL Server Not Reachable" scheduled against "BUILD-WIN32:3306" may not be unscheduled. This rule is required for the product to function properly.

but we only get one message for 'disable':

    * U0166 Heat chart rule "MySQL Agent Not Communicating With Database Server" scheduled against "BUILD-WIN32:3306" may not be disabled. This rule is required for the product to function properly.

yet it does not disable any of these three rules (OK not to disable them; but not OK that there are 2 messages missing).

Marcos Palacios writes: 
The previous comment needs correction: 'Disable' does work on the other Heat Chart rules, it is just that w/'unschedule' the unscheduled rules don't show in the 'current schedule' anymore, but with 'disable' they are still there, yet marked 'disabled' in red (but you have to expand the tree to see it).

Sloan Childers writes: 
fix pushed to allow multiple messages to be displayed in the ui... seems to have fixed the other issue marcos talked about as well

Sloan Childers writes: 
Patch installed in versions => 2.2.0.1501.

Keith Russell writes: 
Patch installed in versions => 2.1.1.1104.

Marcos Palacios writes: 
Tested with service manager build 2.1.1.1104.

First, now we do get the 3 error messages (for 3 rules) we were expecting for the 'disable' action.

However, 2 new issues/side effects have occurred:

(1) for 'unschedule', the white cloud says "Removed 14 schedules" (but only 11 were really removed) so it should say "11" like the cloud for 'disable' says; 
(2) the page does not refresh after the action in either case (disable or unschedule) and so it seems like the action did not work correctly.

Keith Russell writes: 
Patch installed in versions => 2.2.0.1507.

Sloan Childers writes: 
Retested with the latest trunk and 2.1 code and the issue with counts has been fixed.

Marcos Palacios writes: 
Tested with service manager build 2.2.0.1507.

Observed:
(1) for 'unschedule', now there is NO white cloud with any counts. (The white cloud for 'disable' is fine.)
(2) the page shows ALL 14 rules as 'disabled' after the 'disable' action even though 3 rules were not disabled; if you hit refresh, now you see those 3 as 'enabled'. (This is fine for 'unschedule'.)

Marcos Palacios writes: 
This issue is scheduled for version "2.1.x Maint Backlog", so it will be tested in the next 2.1.1 build.

The above mentioned UI observations are from a 2.2 build, which has UI work ongoing. These issues will be tracked separately.

Marcos Palacios writes: 
Verified fixed in Monitor build 2.1.1.1108.

The message has the form:
U0166 Heat chart rule "<rule>" scheduled against "<server>" may not be disabled. This rule is required for the product to function properly.

An entry was added to the 2.1.1 and 2.2.0 changelogs:

Certain heat chart rules cannot be unscheduled or disabled, this is because they are required for correct operation of MySQL Enterprise Monitor. Should an attempt be made to unschedule or disable one of these heat chart rules, a suitable message is now displayed, explaining this requirement.