MySQL Bugs: #45629: PowerPC build

Bug #45629	PowerPC build
Submitted:	20 Jun 2009 6:29	Modified:	6 Aug 2009 14:31
Reporter:	Remi Collet (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench	Severity:	S3 (Non-critical)
Version:	5.1.14	OS:	Linux (Fedora 11)
Assigned to:	Alfredo Kojima	CPU Architecture:	Any
Tags:	CHECKED, Contribution

Description:
Under ppc/ppc64, build failed because bswap32 not defined.

How to repeat:
Build error:

In file included from src/template_string.cc:47:
src/base/arena.h: In member function 'void google::BaseArena::ReturnMemory(void*, size_t)':
src/base/arena.h:211: warning: comparison between signed and unsigned integer expressions
src/template_string.cc: In function 'uint32 UNALIGNED_LOAD32(const void*)':
src/template_string.cc:120: error: 'bswap32' was not declared in this scope

Suggested fix:
Use bswap_32 which is provided.

Patch : http://remi.fedorapeople.org/mysql-workbench-oss-5.1.12.patch

This patch solves this issue and don't break "instel" build.

Many thanks for writing a bug report and sending us a patch.

I will set this to verified so that development will get attention here and will be able to review the patch.

Hello Remi - 

 In order for us to continue the process of reviewing your contribution
 to MySQL - We need you to review and sign the Sun|MySQL contributor
 agreement (the "SCA")

 The process is explained here:
 http://forge.mysql.com/wiki/Sun_Contributor_Agreement

 Getting a signed/approved SCA on file will help us facilitate your
 contribution-- this one, and others in the future.

 Thank you !

 Liz Drachnik  - Program Manager - MySQL

This has been fixed upstream in ctemplate, we have updated the ctemplate sources in our tree which should solve this problem. 

Thanks for the detailed report.

due to lack of a testmachine i cannot verify the fix.
it will be included in 5.1.17 though

An entry was added to the 5.1.17 changelog:

When building MySQL Workbench on PPC/PPC64 on Linux, the build failed because “bswap32” was not defined.

In file included from src/template_string.cc:47:
src/base/arena.h: In member function 'void google::BaseArena::ReturnMemory(void*,
size_t)':
src/base/arena.h:211: warning: comparison between signed and unsigned integer expressions
src/template_string.cc: In function 'uint32 UNALIGNED_LOAD32(const void*)':
src/template_string.cc:120: error: 'bswap32' was not declared in this scope