MySQL Bugs: #45587: Backup of tables using a non-existent storage engine does not give warning/error

Bug #45587	Backup of tables using a non-existent storage engine does not give warning/error
Submitted:	18 Jun 14:21	Modified:	9 Nov 12:14
Reporter:	Jon Olav Hauglid
Status:	Patch queued
Category:	Server: Backup	Severity:	S3 (Non-critical)
Version:	5.4-azalea-bugfixing	OS:	Any
Assigned to:	Ritheesh Vedire	Target Version:
Triage:	Triaged: D4 (Minor)

Description:
During work on Bug#36021, I enabled the backup_no_engine test.
In this test, a backup is made of two tables where one of them
use a non-existent storage engine (from std_data/bug30938.frm).

This latter table is ignored when backup is made, but no 
warnings are given. 

Tracing shows that 
my_error(ER_UNKNOWN_STORAGE_ENGINE, MYF(0), name.str);
is executed in open_binary_frm() in table.cc

How to repeat:
Run the backup_no_engine test.
SHOW WARNINGS; after BACKUP DATABASE db TO "db.backup";
does not report anything.

Suggested fix:
Report unknown storage engine during backup as warning (or even error).

Possible regression of Bug#33562 ?

REFINED PROBLEM DESCRIPTION :
The query s_stream in the function obs::get_db_tables() (file: si_objects.cc):

    SELECT <db_name>, table_name FROM INFORMATION_SCHEMA.TABLES
    WHERE table_schema = '<db_name>' AND table_type = 'BASE TABLE';

does not return the list of tables  in the database , whose *.frm  files are invalid. So,
the backup engine does not know the existence of those tables at all.That is why it
doesn't report any warnings or errors.

INFORMATION_SCHEMA.tables  SELECT inconsistencies. See bug#47697

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85189

2872 Ritheesh Vedire	2009-09-30
      Bug#45587 Backup of tables using a non-existent storage engine does not give
warning/error
      
      
      This happens because backup engine does not know the existence of all invalid
tables
     @ sql/si_objects.cc
        Bug#45587 Backup of tables using a non-existent storage engine does not give
warning/error
        
         The query s_stream in the function obs::get_db_tables() (file: si_objects.cc):
        
            SELECT <db_name>, table_name FROM INFORMATION_SCHEMA.TABLES
            WHERE table_schema = '<db_name>' AND table_type = 'BASE TABLE';
        
        does not return invalid tables  . See bug#47697
        
        So I have changed the query as shown, to get all the tables including invalid
ones from the information_schema.tables. After that back up engine knows about invalid
tables and throws error messages. 
        
        This fix is temporary . once bug#47697 is fixed, the present fix is redundant and
we can revert to original s_stream query.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85213

2876 Ritheesh Vedire	2009-09-30
      Bug#45587 Backup of tables using a non-existent storage engine
      does not give warning/error
      
       This happens because backup engine does not know the existence of
      all invalid tables
     @ mysql-test/suite/backup/t/backup_no_engine.test
        The test file was edited and RESTORE command is removed ( as there is no point in
restoring if backup fails) . This test reports errors for unidentified storage engines
     @ sql/si_objects.cc
        The query s_stream in the function obs::get_db_tables() (file:
        si_objects.cc):
                
                    SELECT <db_name>, table_name FROM INFORMATION_SCHEMA.TABLES
                    WHERE table_schema = '<db_name>' AND table_type = 'BASE
        TABLE';
                
                does not return invalid tables  . See bug#47697
                
                So I have changed the query , to get all the tables
        including invalid ones from the information_schema.tables. After that
        back up engine knows about invalid tables and throws error messages. 
                
                This fix is temporary . once bug#47697 is fixed, the present
        fix is redundant and we can revert to original s_stream query.

Good to push.

Patch rejected. Setting back to in progress.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/89577

2888 Ritheesh Vedire	2009-11-06
      BUG#45587: Backup of tables using a non-existent storage engine does not give
warning/error
     @ mysql-test/suite/backup/r/backup_no_engine.result
        T
     @ mysql-test/suite/backup/t/backup_no_engine.test
        Test case suppresses errors in the Server Log file.

Approved modified patch (with some suggestions).

Approved pending changes required. See patch reply email.

ooops

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/89763

2888 Ritheesh Vedire	2009-11-09
      BUG#45587:Backup of tables using a non-existent storage engine does not give
warning/error.
      
        
     @ mysql-test/suite/backup/t/backup_no_engine.test
        Changed the test case to throw errors. Test case suppresses the errors in the
Server Log.
     @ sql/si_objects.cc
        Changed the query s_stream  in get_db_tables() to return invalid tables. See
BUG#47697.