MySQL Bugs: #43424: rw-splitting.lua is missing resultset_is

Bug #43424	rw-splitting.lua is missing resultset_is_needed = true and other new options
Submitted:	5 Mar 2009 16:35	Modified:	4 Dec 2009 12:59
Reporter:	Diego Medina	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Proxy: Scripts	Severity:	S3 (Non-critical)
Version:	lp r633	OS:	Any
Assigned to:	Jan Kneschke	CPU Architecture:	Any
Tags:	mysql-proxy, resultset_is_needed, rw-splitting

Description:
The rw-splitting.lua script has not been updated to include

resultset_is_needed = true and to account for the new 

.src.name or .dst.name

options

Note, this is the same as http://bugs.mysql.com/bug.php?id=42841 plus a new issue which.

How to repeat:
1- Install the proxy and use the rw-splitting.lua script
2- Send some queries through the proxy
3- Look at the log and notice messages like

(critical) (read_query) [string "/usr/local/mysql-proxy2/share/mysql-proxy/r..."]:179: .address is deprecated. Use .src.name or .dst.name instead 

(critical) proxy-plugin.c:259: read_query_result() in /usr/local/mysql-proxy2/share/mysql-proxy/rw-splitting.lua tries to modify the resultset, but hasn't asked to buffer it in proxy.query:append(..., { resultset_is_needed = true }). We ignore the change to the result-set.

Please see https://code.launchpad.net/~diego-fmpwizard/mysql-proxy/bug-43424/+merge/4259

to see when the fix will be merged to the main MySQL Proxy branch.

This bug will depend on bug#46141

revno: 803
committer: jan@mysql.com
branch nick: trunk
timestamp: Tue 2009-09-01 14:09:10 +0200
message:
  use .dst.name instead of .address (fixes #43424)
------------------------------------------------------------
revno: 802
committer: jan@mysql.com
branch nick: trunk
timestamp: Tue 2009-09-01 14:07:06 +0200
message:
  added { resultset_is_need = true }

Diego Medina writes: 
Verified fixed on 0.8.0

A note has been added to the 0.8.0 changelog: 

The supplied script <filename>rw-splitting.lua</filename> had not been updated to use the new <literal>resultset_is_needed</literal> flag or updated <literal>proxy.connections</literal> structure.