Bug #42937 strings/CHARSET_INFO.txt not included in source distributions

• Submitted: 17 Feb 16:57
• Modified: 13 Apr 21:26
• Reporter: Paul DuBois
• Status: Closed
• Category: Server: Packaging
• Severity: S3 (Non-critical)
• Version: 5.0+
• OS: Any
• Assigned to: Narayanan venkateswaran
• Target Version: 5.0+
• Triage: Triaged: D4 (Minor)

[17 Feb 16:57] Paul DuBois

Description:
The reference manual has instructions for adding new character sets, and refers to a
strings/CHARSET_INFO.txt file that should be present in source distributions. For
example:

http://dev.mysql.com/doc/refman/5.0/en/character-arrays.html

"For a complex character set as implemented in a ctype-MYSET.c file in the strings
directory, there are corresponding arrays: ctype_MYSET[], to_lower_MYSET[], and so forth.
Not every complex character set has all of the arrays. See the existing ctype-*.c files
for examples. See the CHARSET_INFO.txt file in the strings directory for additional
information."

The file is present in the strings directory in the bzr trees, but it's missing from
source distributions. I checked 5.0, 5.1, 6.0: It's missing from all of them.

How to repeat:
Inspection.

Suggested fix:
Please include strings/CHARSET_INFO.txt in source distributions 5.0 and up.

Well, it should be included in 4.1 distributions, too, but I suspect that is a quite low
priority.

[17 Feb 17:23] Miguel Solorzano

Thank you for the bug report.

[11 Mar 8:12] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68848

2773 Narayanan V	2009-03-11
      Bug#42937 strings/CHARSET_INFO.txt not included in source distributions
      
      The reference manual has instructions for adding new character
      sets, and refers to the string/CHARSET_INFO.txt file. This file
      is currently not present in the distribution.
      
      Modify the build to include this file in the distribution.
     @ strings/Makefile.am
        modify EXTRA_DIST to include the CHARSET_INFO file.

[18 Mar 11:19] Alexander Barkov

ok to push

[27 Mar 15:31] Bugs System

Pushed into 5.0.80 (revid:[e-mail]-20090327142516-55gumdxj39z6eijj) (version source
revid:[e-mail]-20090324072904-7w2lxdxzw8hx1rnm) (merge vers: 5.0.80) (pib:6)

[27 Mar 15:56] Bugs System

Pushed into 5.1.34 (revid:[e-mail]-20090327143448-wuuuycetc562ty6o) (version source
revid:[e-mail]-20090324135852-b7s2aqvqe2j2oflt) (merge vers: 5.1.34) (pib:6)

[27 Mar 16:31] Paul DuBois

Noted in 5.0.80, 5.1.34 changelogs.

The strings/CHARSET_INFO.txt file was not included in source
distributions.

Setting report to NDI pending push into 6.0.x.

[13 Apr 11:20] Bugs System

Pushed into 6.0.11-alpha (revid:[e-mail]-20090413084402-snnrocwzktcl88ny) (version
source revid:[e-mail]-20090324142444-ebqulaq1kxexgmw7) (merge vers: 6.0.11-alpha)
(pib:6)

[13 Apr 21:26] Paul DuBois

Noted in 6.0.11 changelog.

[9 May 18:44] Bugs System

Pushed into 5.1.34-ndb-6.2.18 (revid:[e-mail]-20090508185236-p9b3as7qyauybefl)
(version source revid:[e-mail]-20090508185236-p9b3as7qyauybefl) (merge vers:
5.1.34-ndb-6.2.18) (pib:6)

[9 May 19:40] Bugs System

Pushed into 5.1.34-ndb-6.3.25 (revid:[e-mail]-20090509063138-1u3q3v09wnn2txyt)
(version source revid:[e-mail]-20090509063138-1u3q3v09wnn2txyt) (merge vers:
5.1.34-ndb-6.3.25) (pib:6)

[9 May 20:38] Bugs System

Pushed into 5.1.34-ndb-7.0.6 (revid:[e-mail]-20090509154927-im9a7g846c6u1hzc)
(version source revid:[e-mail]-20090509154927-im9a7g846c6u1hzc) (merge vers:
5.1.34-ndb-7.0.6) (pib:6)