MySQL Bugs: #42589: mysql_fix_privilege_tables.sh to be deprecated

Bug #42589	mysql_fix_privilege_tables.sh to be deprecated
Submitted:	4 Feb 2009 10:01	Modified:	24 Mar 2010 16:38
Reporter:	Magnus Blåudd	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server	Severity:	S3 (Non-critical)
Version:	5.0.19,5.1.7,6.0	OS:	Any
Assigned to:	Magnus Blåudd	CPU Architecture:	Any

Description:
The mysql_fix_privilege_tables.sh script has been replaced by mysql_upgrade since 5.0.19 and 5.1.7 and it's now time to remove the remnants of it from next major release - I suggest 6.0.

Quote from the manual:
"
Note

As of MySQL 5.0.19, mysql_fix_privilege_tables is superseded by mysql_upgrade, which should be used instead. See Section 4.4.9, “mysql_upgrade — Check Tables for MySQL Upgrade”.
"

mysql_upgrade runs exactly the same SQL commands, but in a portable way since it's a binary executable. In addition, mysql_upgrade is being tested by mtr.pl on all platforms.

How to repeat:
Read manual, MCI

Suggested fix:
Remove scripts/mysql_fix_privilege_tables.sh and it's Makefile rules.
Remove the setup of $MYSQL_FIX_SYSTEM_TABLES in mtr.pl and the special section's it put in the config file(s).
Remove the test system_mysql_db_fix30020 that is used to test that you should be able to upgrade the system tables from MySQL 3.23.X to the latest version of MySQL - that can't be supported.

Suggested patch

Attachment: bug42589.patch (text/x-patch), 14.06 KiB.

There are also some occurences of this script in support-files/mysql.spec.sh and support-files/SCO/postinstall that should be removed as well.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/69721

3011 Magnus Svensson	2009-03-19
      Bug#42589 mysql_fix_privilege_tables.sh to be deprecated
       - Remove remnants of "mysql_fix_privilege_tables.sh"

Patch approved.

Pushed into 6.0.11-alpha (revid:alik@sun.com-20090413084402-snnrocwzktcl88ny) (version source revid:azundris@mysql.com-20090320180810-jcyb5cq4jcx58zsz) (merge vers: 6.0.11-alpha) (pib:6)

Noted in 5.4.4, 6.0.11 changelogs.

The deprecated mysql_fix_privilege_tables script has been removed.

Noted in 5.4.2 changelog because next 5.4 version will be 5.4.2 and not 5.4.4.

Ignore previous comment about 5.4.2.

To be ported in to mysql-next-mr-bugfixing

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/86016

Pushed to mysql-next-mr-bugfixing

Setting report to Need Merge pending push to Celosia.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103257

Pushed to mysql-trunk-bugfixing

Setting report to Need Merge pending push to Celosia.

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100324081249-yfwol7qtcek6dh7w) (version source revid:alik@sun.com-20100324081113-kc7x1iytnplww91u) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into 5.5.4-m3 (revid:alik@sun.com-20100324081056-6bndv6f0nrvbblhp) (version source revid:alik@sun.com-20100324081056-6bndv6f0nrvbblhp) (merge vers: 5.5.4-m3) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100324081159-5b8juv8ldiqwce8v) (version source revid:alik@sun.com-20100324081105-y72rautcea375zxm) (pib:16)

Noted in 5.5.4 changelog.

Already fixed in earlier 6.0.x.

5.5.4 changelog entry was moved to 5.5.5.