Bug #42589 mysql_fix_privilege_tables.sh to be deprecated
Submitted: 4 Feb 2009 11:01 Modified: 7 Oct 2009 16:01
Reporter: Magnus Blaudd
Status: Patch queued
Category:Server Severity:S3 (Non-critical)
Version:5.0.19,5.1.7,6.0 OS:Any
Assigned to: Magnus Blaudd Target Version:6.0-rc
Triage: Triaged: D3 (Medium)

[4 Feb 2009 11:01] Magnus Blaudd 
Description:
The mysql_fix_privilege_tables.sh script has been replaced by mysql_upgrade since 5.0.19
and 5.1.7 and it's now time to remove the remnants of it from next major release - I
suggest 6.0.

Quote from the manual:
"
Note

As of MySQL 5.0.19, mysql_fix_privilege_tables is superseded by mysql_upgrade, which
should be used instead. See Section 4.4.9, “mysql_upgrade — Check Tables for MySQL
Upgrade”.
"

mysql_upgrade runs exactly the same SQL commands, but in a portable way since it's a
binary executable. In addition, mysql_upgrade is being tested by mtr.pl on all
platforms.

How to repeat:
Read manual, MCI

Suggested fix:
Remove scripts/mysql_fix_privilege_tables.sh and it's Makefile rules.
Remove the setup of $MYSQL_FIX_SYSTEM_TABLES in mtr.pl and the special section's it put
in the config file(s).
Remove the test system_mysql_db_fix30020 that is used to test that you should be able to
upgrade the system tables from MySQL 3.23.X to the latest version of MySQL - that can't
be supported.
[4 Feb 2009 11:25] Magnus Blaudd 
Suggested patch

Attachment: bug42589.patch (text/x-patch), 14.06 KiB.
[4 Feb 2009 11:26] Magnus Blaudd 
There are also some occurences of this script in support-files/mysql.spec.sh and
support-files/SCO/postinstall that should be removed as well.
[19 Mar 2009 10:27] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/69721

3011 Magnus Svensson	2009-03-19
      Bug#42589 mysql_fix_privilege_tables.sh to be deprecated
       - Remove remnants of "mysql_fix_privilege_tables.sh"
[20 Mar 2009 10:52] Kristofer Pettersson 
Patch approved.
[13 Apr 2009 11:20] Bugs System 
Pushed into 6.0.11-alpha (revid:alik@sun.com-20090413084402-snnrocwzktcl88ny) (version
source revid:azundris@mysql.com-20090320180810-jcyb5cq4jcx58zsz) (merge vers:
6.0.11-alpha) (pib:6)
[29 Jun 2009 20:42] Paul DuBois 
Noted in 5.4.4, 6.0.11 changelogs.

The deprecated mysql_fix_privilege_tables script has been removed.
[12 Aug 2009 23:41] Paul DuBois 
Noted in 5.4.2 changelog because next 5.4 version will be 5.4.2 and not 5.4.4.
[15 Aug 2009 0:39] Paul DuBois 
Ignore previous comment about 5.4.2.
[6 Oct 2009 11:08] Magnus Blaudd 
To be ported in to mysql-next-mr-bugfixing
[7 Oct 2009 15:42] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/86016
[7 Oct 2009 16:01] Magnus Blaudd 
Pushed to mysql-next-mr-bugfixing