MySQL Bugs: #42120: mysql-connector-odbc fails to build with mysql 5.1.30 because of "bool" breakage

Bug #42120	mysql-connector-odbc fails to build with mysql 5.1.30 because of "bool" breakage
Submitted:	14 Jan 23:04	Modified:	28 Jan 14:52
Reporter:	[ name withheld ]
Status:	Closed
Category:	Connector/ODBC	Severity:	S2 (Serious)
Version:	5.1.5r1144	OS:	Any
Assigned to:	Tony Bedford	Target Version:

Description:
The mysql 5.1.30 headers intentionally break usage of "bool" by #define'ing it as
something that causes a syntax error.  I'm fairly dubious that that's a good plan to
begin with, but if you're going to do that you ought to make your own client software
deal with it ... there are half a dozen uses of plain bool in the myodbc sources.

How to repeat:
1. Install mysql 5.1.30

2. Try to compile mysql-connector-odbc

Suggested fix:
Either take out that #define or change bool to my_bool everywhere in myodbc.

Thanks for your report.

I believe this problem is already fixed:
revno: 806
committer: Jess Balint <jbalint@mysql.com>
branch nick: odbc51_merge
timestamp: Tue 2008-10-28 13:52:50 -0500
message:
  use my_bool instead of bool to comply with MySQL 5.1 headers

Now I'm wondering what sources do you use and about other little info missing from this
report... My "bzr log" shows rev. 822 as the last one, how come you have r1144?
Officially, c/ODBC 5.1 is built against MySQL server 5.0.67 libraries so you might wish
to rebuild with latest c/ODBC sources against both server versions.

I'm using the currently released sources available from the bottom of this page:
http://dev.mysql.com/downloads/connector/odbc/5.1.html

What else should I be using?  If there isn't an official release that works with mysql
5.1, why not?

Hi. Sources are hosted in Launchpad, namely
http://bazaar.launchpad.net/~myodbc-developers/myodbc/5.1/

Thanks, but I'm looking for the latest released version, not the bleeding-edge development
tip.  Maybe I should explain that I'm trying to package this for Fedora, and distro policy
encourages use of stable upstream releases.

This is fixed in the 5.1.6 tree and will be included in the next release.

I still fail to see what do you think we're doing wrong? Your particular problem *is*
solved but not released yet. So, as Jess already confirmed, it will be in next release.
Revision mismatch is probably due to SVN -> BZR switch. Tony please fix this if you can.

The only thing wrong is that the released version of myodbc still doesn't build against
mysql 5.1, two months after 5.1 went GA.  I'd have expected somebody to test the
combination long ago ...

Anyway, that's water over the dam, and you might as well close this as "fixed in SCM". 
(And get on with pushing 5.1.6 out the door ;-))

An entry was added to the 5.1.6 changelog:

Connector/ODBC failed to build with MySQL 5.1.30 due to incorrect use of the data type
bool.