MySQL Bugs: #40551: Agent 2.0 text installer creates wrong configuration when using --enableproxy 0

Bug #40551	Agent 2.0 text installer creates wrong configuration when using --enableproxy 0
Submitted:	6 Nov 2008 13:27	Modified:	11 Nov 2008 16:11
Reporter:	Kay Roepke	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Installing	Severity:	S3 (Non-critical)
Version:	2.0.0.7088 (beta)	OS:	Linux
Assigned to:	BitRock Merlin	CPU Architecture:	Any

Description:
When the agent (2.0.0.7088) is installed using the text mode installer and --enableproxy 0 is given the installer should also remove the quan.lua in the agent-item-files option in the ini file.

How to repeat:
Disabling the proxy in the installer creates the ini file with this line:
agent-item-files = share/mysql-proxy/items/quan.lua,share/mysql-proxy/items/items-mysql-monitor.xml

and that leads to:
2008-11-05 18:09:00: (critical) job_collect_lua.c:578: 'instances = function () ... end' failed for mysql::statementsummary: ...l/enterprise/agent3/share/mysql-proxy/items/quan.lua:144: attempt to index global 'proxy' (a nil value)

Suggested fix:
Removing the share/mysql-proxy/items/quan.lua part in the agent-item-files option fixes the problem.
The installer should take that into account when creating the configuration file.

Patch sent to Keith.

Patch appled in versions 2.0.0.7093.

Verified fixed in build 2.0.0.7093.

An entry was added to the 2.0 changelog:

When the agent was installed using the command line installer and --enableproxy 0 was specified, the installer should have removed quan.lua from the agent-item-files option in the INI file.