MySQL Bugs: #40542: Add Windows equivalents of getrusage() in Profiling code

Bug #40542	Add Windows equivalents of getrusage() in Profiling code
Submitted:	6 Nov 2008 9:20	Modified:	6 Nov 2008 9:44
Reporter:	Shane Bester (Platinum Quality Contributor)	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: Windows	Severity:	S3 (Non-critical)
Version:	5.1.28, 5.1.29	OS:	Windows
Assigned to:	Assigned Account	CPU Architecture:	Any
Tags:	profiling

Description:
According to the 5.1.28 change history, profiling feature should be included.
Solaris build contained the feature, but not windows build:

on windows 5.1.28:

mysql> set profiling=1;
ERROR 1193 (HY000): Unknown system variable 'profiling'
mysql> show global variables like '%profil%';
Empty set (0.00 sec)

on solaris 5.1.28:

mysql> show global variables like '%profil%';
+------------------------+-------+
| Variable_name          | Value |
+------------------------+-------+
| profiling              | ON    |
| profiling_history_size | 15    |
+------------------------+-------+

How to repeat:
http://dev.mysql.com/doc/refman/5.1/en/news-5-1-28.html

"Added the SHOW PROFILES and SHOW PROFILE statements to display statement profile data"

"These options are enabled by default;"...

set profiling=1;

Suggested fix:
windows is a major platform, and this feature must be implemented/built in these builds.

Verified with 5.1.29 also:

C:\Program Files\MySQL\MySQL Server 5.0\bin>mysql -uroot -proot -P3310 test
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 1
Server version: 5.1.29-rc-community MySQL Community Server (GPL)

Type 'help;' or '\h' for help. Type '\c' to clear the buffer.

mysql> set profiling=1;
ERROR 1193 (HY000): Unknown system variable 'profiling'
mysql> show global variables like '%profil%';
Empty set (0.16 sec)

mysql> show profile;
ERROR 1289 (HY000): The 'SHOW PROFILE' feature is disabled; you need MySQL built
 with 'enable-profiling' to have it working
mysql>

Profiling was enabled in the source by the 5.1 team, this is not a build team issue. Re-assigning lead.

mysql> show global variables like '%profil%';
+------------------------+-------+
| Variable_name          | Value |
+------------------------+-------+
| profiling              | ON    |
| profiling_history_size | 15    |
+------------------------+-------+
2 rows in set (0.00 sec)

mysql>
mysql> select version();
+----------------------+
| version()            |
+----------------------+
| 5.1.30-community-log |
+----------------------+
1 row in set (0.02 sec)

so, this bug can be closed ?

Build problem fixed, now other half of bug left:  Find replacement for the columns that are populated by getrusage() on other OSes.

I suspect this doesn't qualify as P2, though.  Omer?

Does the patch attached to BUG#50057 provide the missing piece to this bug?