Bug #39795 Falcon: Online add index does not support index with non-null columns
Submitted: 2 Oct 2008 1:13 Modified: 9 Jan 15:05
Reporter: Christopher Powers
Status: Closed
Category:Server: Falcon Severity:S2 (Serious)
Version: OS:Any
Assigned to: Christopher Powers Target Version:6.0.8
Tags: F_ONLINE ALTER
Triage: Triaged: D2 (Serious)

[2 Oct 2008 1:13] Christopher Powers 
Description:
By design, Falcon online add/drop index does not support indexes having non-null columns
or primary keys. This restriction is no longer necessary and should be removed.

How to repeat:
CREATE TABLE t1 (s1 INT NOT NULL) ENGINE=FALCON;
ALTER ONLINE TABLE t1 ADD INDEX i1 (s1);

You will receive this error:

ERROR 1235 (42000): This version of MySQL doesn't yet support 'alter online table t1 add
index i1 (s1)'

Suggested fix:
Remove explicit check for non-nullable columns and primary key in
StorageEngine::check_if_supported_alter(), ha_falcon.cpp.
[2 Oct 2008 2:12] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54992

2845 Christopher Powers	2008-10-01
      Bug#39711 "Running falcon_bug_34351_C shows increasing memory usage"
      Bug#39795 "Falcon: Online add index does not support index with non-null columns"
      Bug#39796 "Falcon: Reference count decrement not atomic"
[2 Oct 2008 2:13] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54993

2845 Christopher Powers	2008-10-01
      Bug#39711 "Running falcon_bug_34351_C shows increasing memory usage"
      Bug#39795 "Falcon: Online add index does not support index with non-null columns"
      Bug#39796 "Falcon: Reference count decrement not atomic"
[2 Oct 2008 2:16] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54994

2845 Christopher Powers	2008-10-01
      Bug#39711 "Running falcon_bug_34351_C shows increasing memory usage"
      Bug#39795 "Falcon: Online add index does not support index with non-null columns"
      Bug#39796 "Falcon: Reference count decrement not atomic"
[2 Oct 2008 8:48] John H. Embretsen 
Patch not approved, regression test falcon_online_index needs to be updated according to
changed specifications/restrictions.

See http://lists.mysql.com/commits/54997
[3 Oct 2008 7:18] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55169

2851 Christopher Powers	2008-10-03
      Bug#39795 "Falcon: Online add index does not support index with non-null columns"
      
      Lift restriction on adding online indexes having non-null columns.
[9 Jan 15:05] MC Brown 
A note has been added to the 6.0.8 changelog: 

Falcon did not support online add/drop index creation on tables using a NOT NULL column.