Bug #39059 push_warning_printf: Warnings are raised as errors

• Submitted: 27 Aug 2008 0:15
• Modified: 11 Sep 2008 21:30
• Reporter: Marc Alff
• Status: Closed
• Category: Server: Errors
• Severity: S3 (Non-critical)
• OS: Any
• Assigned to: Marc Alff
• Target Version: 6.0-rc
• Triage: D4 (Minor) / R1 (None/Negligible) / E1 (None/Negligible)

[27 Aug 2008 0:15] Marc Alff

Description:
This is a follow up on bug#36777.

Even after the fix for 36777, the server code still contains improper calls
to push_warning:

see file sql/backup/logger.cc, method Logger::write_message():

     push_warning_printf(current_thd, MYSQL_ERROR::WARN_LEVEL_ERROR,

see file sql/sql_table.cc, function mysql_create_table_no_lock():

    push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_ERROR,

How to repeat:
Code review

Suggested fix:
     push_warning_printf(current_thd, MYSQL_ERROR::WARN_LEVEL_WARN,

[27 Aug 2008 17:49] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52750

2807 Marc Alff	2008-08-27
      Bug#39059 (push_warning_printf: Warnings are raised as errors)
      
      Fixed the calls to push_warning_printf() to not report WARN_LEVEL_ERROR
      warnings.

[11 Sep 2008 21:30] Paul DuBois

Noted in 6.0.8 changelog.

Some warnings were being reported as errors.

[14 Sep 2008 2:45] Bugs System

Pushed into 6.0.7-alpha  (revid:[e-mail]-20080827154832-xa4mijbjxxdcxhpj)
(version source revid:[e-mail]-20080804094710-jb2qpqxpf2ir2gf3) (pib:3)