MySQL Bugs: #38699: IllegalArgumentException thrown when invoking close

Bug #38699	IllegalArgumentException thrown when invoking close
Submitted:	10 Aug 2008 15:22	Modified:	1 Sep 2008 18:09
Reporter:	Chris Webster	Email Updates:
Status:	Can't repeat	Impact on me:	None
Category:	Connector / J	Severity:	S1 (Critical)
Version:	5.1.6	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
An IllegalArgmentException is thrown from com.mysql.jdbc.jdbc2.optional.JDBC4PreparedStatementWrapper.close (line 70) when this method is invoked because this.pooledConnection has been set to null in the super.close() (line 67) invocation. 

This presents a serious problem as this is an unexpected RuntimeException. 

How to repeat:
Invoke the close method on com.mysql.jdbc.jdbc2.optional.JDBC4PreparedStatementWrapper.close(JDBC4PreparedStatementWrapper.java:70)

Suggested fix:
The way to resolve this without changing the current design (relying on an instance of StatementWrapper), would be to change the JDBC4PreparedStatementWrapper.close method to be something like:

public void close() throws SQLException {
    JDBC4MysqlPooledConnection currentConnection = 			(JDBC4MysqlPooledConnection) this.pooledConnection;
     try {
	super.close();
     } finally {
	try {
	    currentConnection.fireStatementEvent(
		new StatementEvent(currentConnection, this));
	} finally {
	    this.unwrappedInterfaces = null;
	}
     }
}

This approach caches the pooledConnection so when it is nullified in StatementWrapper the local reference is maintained. Another possible approach would be to move the event firing to StatementWrapper (perhaps in a method with a boolean parameter which specified whether to fire an event or not). This approach would provide better encapsulation.

relevant portion of the stack trace

Attachment: stacktrace.txt (text/plain), 2.71 KiB.

Hi Chris and thanks for your report.

Can you please attach small but complete test case proving your point and add some more info on JDK/other SW used.

Hi Tonci.  We don't have a direct test case.  The situation is that we were using GlassFish connection pool with datasource-classname="com.mysql.jdbc.jdbc2.optional.MysqlConnectionPoolDataSource" and res-type="javax.sql.DataSource".  If we use res-type="javax.sql.ConnectionPoolDataSource" then we hit the exception stack.  Wouldn't the exception stack be enough info to fix the code?

Simple test case to reproduce the "null source" exception.

Attachment: Main.java (application/octet-stream, text), 988 bytes.

Hi Tonci, I attached a simple test case.  I am using JDK 6.

test case provided

This should be fixed in the head of 5.1, as the fix was needed when we fixed Bug#35489. Have you tried a nightly snapshot build of 5.1? It should have the fix for this. See http://downloads.mysql.com/snapshots.php

Thanks Mark. Anyone tried latest code?

The snapshots page does not have any links to download.  It seems that the build is broken.

Nam,

please scroll down the page or use this link: http://downloads.mysql.com/snapshots/mysql-connector-java-5.1/mysql-connector-java-5.1-nig... or http://downloads.mysql.com/snapshots/mysql-connector-java-5.1/mysql-connector-java-5.1-nig...

Verified that the problem is fixed with mysql-connector-java-5.1-nightly-20080901-bin.jar

Thanks Nam, closing the report now as it is fixed in source trees.

Bug #37645 was marked as duplicate of this one.