Bug #38311 Some tests use 'rm', which is not portable
Submitted: 23 Jul 2008 14:39 Modified: 18 Oct 2008 17:41
Reporter: Alexander Nozdrin
Status: Closed
Category:Tests: Server Severity:S3 (Non-critical)
Version:6.0-BK OS:Any
Assigned to: Patrick Crews Target Version:6.0
Tags: sporadic, test failure, pushbuild
Triage: D3 (Medium)

[23 Jul 2008 14:39] Alexander Nozdrin 
Description:
'rm' is not portable, that leads to sporadic failures on some systems.

List of usages:
----------------------------------------------------
extra/rpl_tests/rpl_ndb_apply_status.test:--exec rm
$MYSQLTEST_VARDIR/tmp/master_apply_status.sql
extra/rpl_tests/rpl_ndb_apply_status.test:--exec rm
$MYSQLTEST_VARDIR/tmp/slave_apply_status.sql
extra/rpl_tests/rpl_EE_err.test:system rm $MYSQLTEST_VARDIR/master-data/test/t1.MYI ;
suite/ndb/t/ndb_alter_table_online.test:--exec rm
$MYSQLTEST_VARDIR/master-data/test/tmp.dat || true
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t1.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t2.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t3.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t4.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t1.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t2.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t3.txt
suite/ndb/t/ndb_restore_print.test:--exec rm -f $MYSQLTEST_VARDIR/tmp/t4.txt
suite/ndb/t/ndb_dd_ddl.test:--exec rm $MYSQLTEST_VARDIR/tmp/t1.frm
suite/rpl_ndb_big/t/rpl_ndb_bank.test:--exec rm $MYSQLTEST_VARDIR/tmp.dat || true
suite/binlog/t/binlog_start_comment.test:#--system rm
$MYSQLTEST_VARDIR/tmp/binlog_start_comment.binlog
suite/binlog/t/binlog_killed_simulate.test:system rm
$MYSQLTEST_VARDIR/tmp/binlog_killed_bug27571.binlog;
suite/binlog/t/binlog_killed_simulate.test:system rm
$MYSQLTEST_VARDIR/tmp/binlog_killed_bug27571.binlog;
suite/rpl/t/rpl_row_mysqlbinlog.test:--exec rm $MYSQLTEST_VARDIR/tmp/master.sql
suite/rpl/t/rpl_row_mysqlbinlog.test:--exec rm $MYSQLTEST_VARDIR/tmp/remote.sql
suite/rpl/t/rpl_row_mysqlbinlog.test:--exec rm $MYSQLTEST_VARDIR/tmp/remote.sql
suite/rpl/t/rpl_row_mysqlbinlog.test:--exec rm $MYSQLTEST_VARDIR/tmp/local.sql
suite/ndb_team/t/rpl_ndb_dd_advance.test:--exec rm $MYSQLTEST_VARDIR/tmp.dat || true
suite/ndb_team/t/rpl_ndb_dd_advance.test:--exec rm
$MYSQLTEST_VARDIR/tmp/RPL_DD_ADV_M.sql
suite/ndb_team/t/rpl_ndb_dd_advance.test:--exec rm
$MYSQLTEST_VARDIR/tmp/RPL_DD_ADV_S.sql
t/distinct.test:#--exec rm $MYSQL_TEST_DIR/var/tmp/data1.tmp
t/distinct.test:#--exec rm $MYSQL_TEST_DIR/var/tmp/data2.tmp
t/drop-no_root.test:--echo rm mysql_test/t1.MYD mysql_test/t1.MYI
t/drop-no_root.test:--exec rm $MYSQLTEST_VARDIR/master-data/mysql_test/t1.MYD
t/drop-no_root.test:--exec rm $MYSQLTEST_VARDIR/master-data/mysql_test/t1.MYI
t/ctype_big5.test:--exec rm $MYSQLTEST_VARDIR/master-data/test/t1.txt
t/outfile.test:--exec rm $MYSQLTEST_VARDIR/tmp/outfile-test.4
t/create_not_windows.test:--system rm -f $MYSQLTEST_VARDIR/master-data/test/t1.frm
t/partition_mgm_err2.test:--system rm -rf $MYSQLTEST_VARDIR/tmp/bug14354
t/partition_mgm_err2.test:--system rm -rf $MYSQLTEST_VARDIR/tmp/bug14354
t/loadxml.test:--system rm $MYSQLTEST_VARDIR/loadxml-dump.xml
t/mysqlbinlog_base64.test:--exec rm $MYSQLTEST_VARDIR/tmp/mysqlbinlog_base64.sql
----------------------------------------------------

How to repeat:
PushBuild.
[20 Sep 2008 8:22] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54391

2683 Patrick Crews	2008-09-20
      Bug#38311 Some tests use 'rm' which is not portable
      Substituted use of MTR's remove_file function in the tests
      Started with 5.0 tree and will clean up any offenders discovered during upmerge.
[23 Sep 2008 11:24] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54477

2684 Patrick Crews	2008-09-23 [merge]
      Bug#38311 - Fix of some cruft from remove_files in ndb_autodiscover.test, clean up
of distinct.test,
      and replacing error numbers with error names.
[30 Sep 2008 15:51] Matthias Leich 
Result of second review:
Ok to push
If time permits please correct
mysql-test/t/symlink.test
around line 86
# Should fail becasue the file t9.MYI already exist in 'run'
              because

# Should fail becasue the file t9.MYD already exist in 'tmp'
              because
Regards,

Matthias
[1 Oct 2008 2:40] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54822

2687 Patrick Crews	2008-09-30
      Bug#38311 Some tests use 'rm' which is not portable
      Fix to repair PB errors (needed to simulate rm -f)
[1 Oct 2008 2:54] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54823

2687 Patrick Crews	2008-09-30
      Bug#38311  Some tests use 'rm' which is not portable
      
      Repush of change to fix tests on Pushbuild.
[1 Oct 2008 4:15] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54829

2687 Patrick Crews	2008-09-30
      Bug#38311  Some tests use 'rm' which is not portable
      
      Repush of change to fix tests on Pushbuild.
[2 Oct 2008 16:15] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55085

2839 Patrick Crews	2008-10-02
      Bug#39785 Test binlog.binlog_stm_row failing on Pushbuild
      Bug#38311 Some tests use 'rm' which is not portable
      
      Fix of broken pushbuild tests for 6.0-5.1.29-rc tree.  Also removal of 
      some 'rm' calls that weren't present in -bugteam trees.
[2 Oct 2008 16:19] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55091

2839 Patrick Crews	2008-10-02
      Bug#39785 Test binlog.binlog_stm_row failing on Pushbuild
      Bug#38311 Some tests use 'rm' which is not portable
      
      Fix of broken pushbuild tests for 6.0-5.1.29-rc tree.  Also removal of 
      some 'rm' calls that weren't present in -bugteam trees.
[2 Oct 2008 16:22] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55092

2841 Patrick Crews	2008-10-02
      bug#38311 Some tests use 'rm' which is not portable
      Fix for broken Pushbuild  will skip the test rather than failing (embedded server)
[2 Oct 2008 16:25] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55093

2841 Patrick Crews	2008-10-02
      Bug#38311 Some tests use 'rm' which is not portable
      Fix of commented out line that is causing PB failures (embedded server)
[2 Oct 2008 16:26] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/55094

2841 Patrick Crews	2008-10-02
      Bug#38311 Some tests use 'rm' which is not portable
      Fix of commented out line that is causing PB failures (embedded server)
[9 Oct 2008 20:04] Bugs System 
Pushed into 5.1.30  (revid:patrick.crews@sun.com-20081001005406-ena1z8vmyuxwob29) (version
source revid:patrick.crews@sun.com-20081001020150-btzvg0m3xdpzqjba) (pib:4)
[15 Oct 2008 17:08] Paul DuBois 
This is actually pushed to 5.1.29, not 5.1.30.
[15 Oct 2008 19:40] Paul DuBois 
Test case changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.
[17 Oct 2008 18:43] Bugs System 
Pushed into 6.0.8-alpha  (revid:patrick.crews@sun.com-20081002141427-0iau82dmfg0e3vst)
(version source revid:kgeorge@mysql.com-20081007153644-uypi14yjgque9obc) (pib:5)
[18 Oct 2008 17:41] Paul DuBois 
No changelog entry needed.
[28 Oct 2008 22:04] Bugs System 
Pushed into 5.1.29-ndb-6.2.17 
(revid:patrick.crews@sun.com-20081001005406-ena1z8vmyuxwob29) (version source
revid:tomas.ulin@sun.com-20081028140209-u4emkk1xphi5tkfb) (pib:5)
[28 Oct 2008 23:23] Bugs System 
Pushed into 5.1.29-ndb-6.3.19 
(revid:patrick.crews@sun.com-20081001005406-ena1z8vmyuxwob29) (version source
revid:tomas.ulin@sun.com-20081028194045-0353yg8cvd2c7dd1) (pib:5)
[1 Nov 2008 10:48] Bugs System 
Pushed into 5.1.29-ndb-6.4.0 
(revid:patrick.crews@sun.com-20081001005406-ena1z8vmyuxwob29) (version source
revid:jonas@mysql.com-20081101082305-qx5a1bj0z7i8ueys) (pib:5)