Bug #38290 valgrind warnings in binlog_base64_flag
Submitted: 22 Jul 2008 17:41 Modified: 6 Oct 2008 15:59
Reporter: Sven Sandberg Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Replication Severity:S7 (Test Cases)
Version:5.1 OS:Any
Assigned to: Zhenxing He CPU Architecture:Any
Tags: binlog_base64_flag, pushbuild, test failure, valgrind

[22 Jul 2008 17:41] Sven Sandberg 
Description:
valgrind warnings in pushbuild:

master.err: binlog.binlog_base64_flag: ==9469==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)
master.err: binlog.binlog_base64_flag: ==9469==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)
master.err: binlog.binlog_base64_flag: ==19755==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)
master.err: binlog.binlog_base64_flag: ==19755==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)
master.err: binlog.binlog_base64_flag: ==32301==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)
master.err: binlog.binlog_base64_flag: ==32301==    at 0x4A20A56: malloc (vg_replace_malloc.c:149)

How to repeat:
https://intranet.mysql.com/secure/pushbuild/showpush.pl?dir=bzr_mysql-5.1&order=19 pb-valgrind-*/n_stm
[23 Jul 2008 17:56] Sven Sandberg 
Note: this may already be fixed in 5.1-rpl. See also BUG#38316
[11 Aug 2008 9:26] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51267

2656 He Zhenxing	2008-08-11
      BUG#38290 valgrind warnings in binlog_base64_flag
      
      The problem is because we forget to free the event allocated
      in mysql_client_binlog_statement when an error occured while
      applying the event.
[14 Aug 2008 2:25] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51588

2675 He Zhenxing	2008-08-14
      BUG#38290 valgrind warnings in binlog_base64_flag
      
      The problem was because the event allocated in mysql_client_binlog_statement
      was not freed when an error occured while applying the event.
[14 Aug 2008 2:43] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51589

2677 He Zhenxing	2008-08-14
      BUG#38290 valgrind warnings in binlog_base64_flag
      
      The problem was because the event allocated in mysql_client_binlog_statement
      was not freed when an error occured while applying the event.
[14 Aug 2008 3:32] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51591

2677 He Zhenxing	2008-08-14
      BUG#38290 valgrind warnings in binlog_base64_flag
      
      The problem was because the event allocated in mysql_client_binlog_statement
      was not freed when an error occured while applying the event.
[14 Aug 2008 6:50] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51599

2678 He Zhenxing	2008-08-14 [merge]
      auto merge
[14 Aug 2008 7:17] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51600

2677 He Zhenxing	2008-08-14 [merge]
      Merge with mysql-5.1-rpl-testfixes
[14 Aug 2008 8:20] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51605

2685 He Zhenxing	2008-08-14 [merge]
      Merge 5.1-rpl-testfixes -> 6.0-rpl-testfixes
[15 Aug 2008 2:02] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51688

2769 He Zhenxing	2008-08-15 [merge]
      Merge 6.0-rpl-testfixes -> 6.0
[18 Aug 2008 10:14] Zhenxing He 
pushed to mysql-5.1-rpl-testfixes, mysql-5.1-rpl, mysql-5.1
pushed to mysql-6.0-rpl-testfixes
[19 Aug 2008 19:51] Bugs System 
Pushed into 6.0.7-alpha  (revid:hezx@mysql.com-20080814024210-s0pzhebq3xn2jh9w) (version source revid:sven@mysql.com-20080818175803-c1nutd5773r6b4gd) (pib:3)
[27 Aug 2008 1:25] Paul DuBois 
Noted in 6.0.7 changelog.

A failure to clean up binary log events was
corrected (detected by Valgrind).

Setting report to NDI pending push into 5.1.x.
[28 Aug 2008 20:17] Bugs System 
Pushed into 6.0.7-alpha  (revid:cbell@mysql.com-20080822132131-uveo6wiuecy6m2b8) (version source revid:cbell@mysql.com-20080822132131-uveo6wiuecy6m2b8) (pib:3)
[29 Aug 2008 0:48] Paul DuBois 
Setting report to NDI pending push into 5.1.x.
[1 Sep 2008 8:04] Zhenxing He 
Fixed a memroy leak problem when executing BINLOG command found by valgrind. The memory allocated for the event when executing BINLOG command was not freed when applying the event failed. This patch fixed it.
[2 Sep 2008 18:17] Paul DuBois 
Setting report to NDI pending push into 5.1.x.
[14 Sep 2008 0:15] Bugs System 
Pushed into 6.0.6-alpha  (revid:hezx@mysql.com-20080814024210-s0pzhebq3xn2jh9w) (version source revid:lars-erik.bjork@sun.com-20080717135217-z3zlwwy465hmc20e) (pib:3)
[16 Sep 2008 4:26] Paul DuBois 
Setting report to NDI pending push into 5.1.x.
[6 Oct 2008 15:59] Paul DuBois 
Noted in 5.1.28 changelog.