MySQL Bugs: #35934: mysql_upgrade calls mysqlcheck with insufficient parameters

Bug #35934	mysql_upgrade calls mysqlcheck with insufficient parameters
Submitted:	9 Apr 2008 12:25	Modified:	24 Feb 2009 20:42
Reporter:	Philip Stoev	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Command-line Clients	Severity:	S2 (Serious)
Version:	5.1	OS:	Any
Assigned to:	Alexey Botchkov	CPU Architecture:	Any

Description:
When upgrading from 5.0 to 5.1. , table names created in 5.0 which contain non-alphanumeric characters appear in 5.1 with a '#mysql50#' prefix. To fix this , mysqlcheck must be called with --fix-table-names option. Unfortunately, mysql_upgrade calls mysqlcheck with --check-upgrade --auto-repair, which does not cause the table names to be adjusted.

How to repeat:
In 5.0: CREATE TABLE `a b` (f1 integer);
In 5.1: SHOW TABLES:
+----------------+
| Tables_in_test |
+----------------+
| #mysql50#a b   |
+----------------+

./mysql_upgrade, then SHOW TABLES:

+----------------+
| Tables_in_test |
+----------------+
| #mysql50#a b   |
+----------------+

./mysqlcheck --fix-table-names then SHOW TABLES:

+----------------+
| Tables_in_test |
+----------------+
| a b            |
+----------------+

Suggested fix:
Either fix mysql_upgrade to call mysqlcheck with the correct parameters to force table name fixing, or make table name fixing run by default in mysqlcheck regardless of parameters.

Thank you for the report.

Verified as described.

elated tobug#30654

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

http://lists.mysql.com/commits/47878

2656 Alexey Botchkov 2008-06-15
      Bug #35934 mysql_upgrade calls mysqlcheck with insufficient parameters.

This is fine, IFF we can be sure that the mysqlcheck will be of the v5.1 server.  Should it fail if it's from a version from before "fix-db-names" and "fix-table-names" was available?  I think so.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/61015

2733 Alexey Botchkov	2008-12-09
      Bug#35934      mysql_upgrade calls mysqlcheck with insufficient parameters
          modifying the original fix.
          As it turned out --fix-db-names option of the mysqlcheck suppress
          the --check_upgrade option, so we have to call the mysqlcheck twice
          from the mysql_upgrade.
      
      per-file comments:
        client/mysql_upgrade.c
      Bug#35934      mysql_upgrade calls mysqlcheck with insufficient parameters

It does not fix db names as well, not only table names

Pushed into 5.1.31 (revid:joro@sun.com-20090115053147-tx1oapthnzgvs1ro) (version source revid:azundris@mysql.com-20081230114838-cn52tu180wcrvh0h) (merge vers: 5.1.31) (pib:6)

Pushed into 5.1.31-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090119095303-uwwvxiibtr38djii) (version source revid:tomas.ulin@sun.com-20090115073240-1wanl85vlvw2she1) (merge vers: 5.1.31-ndb-6.2.17) (pib:6)

Pushed into 5.1.31-ndb-6.3.21 (revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (version source revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (merge vers: 5.1.31-ndb-6.3.21) (pib:6)

Pushed into 5.1.31-ndb-6.4.1 (revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (version source revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (merge vers: 5.1.31-ndb-6.4.1) (pib:6)

Pushed into 6.0.10-alpha (revid:joro@sun.com-20090119171328-2hemf2ndc1dxl0et) (version source revid:azundris@mysql.com-20081230114916-c290n83z25wkt6e4) (merge vers: 6.0.9-alpha) (pib:6)

The databases are still not fixed with upgrade.
To fix the database names (if they contain "-" symbol for example) you will need to run:
mysqlcheck --check-upgrade --fix-db-names --fix-table-names --all-databases

I have checked mysql 5.1.31 and now both databases and tables are fixed when running mysql_upgrade

Noted in 5.1.31, 6.0.10 changelogs.

For upgrades to MySQL 5.1 or higher, mysql_upgrade did not re-encode
database or table names that contained non-alphanumeric characters.
(They would still appear after the upgrade with the #mysql50# prefix
described in http://dev.mysql.com/doc/refman/5.1/en/identifier-mapping.html.)
To correct this problem, it was necessary to run mysqlcheck
--all-databases --check-upgrade --fix-db-names --fix-table-names
manually. mysql_upgrade now runs that command automatically after
performing the initial upgrade.