Bug #34053 normal users can enable innodb_monitor logging
Submitted: 25 Jan 2008 14:14 Modified: 17 Apr 2008 19:05
Reporter: Shane Bester
Status: Closed
Category:Server: InnoDB Severity:S3 (Non-critical)
Version:5.0.54, 5.1.24, 6.0 OS:Any
Assigned to: Timothy Smith Target Version:
Tags: v6, fixed in pre-v6
Triage: D3 (Medium) / R3 (Medium) / E3 (Medium)

[25 Jan 2008 14:14] Shane Bester 
Description:
Seems you don't need any special privileges to enable the innodb_monitor,
innodb_table_monitor, innodb_lock_monitor, and innodb_tablespace_monitor described in
http://dev.mysql.com/doc/refman/5.0/en/innodb-monitor.html

How to repeat:
mysql -uroot -h127.0.0.1
flush privileges;
drop user 'shane'@'127.0.0.1';
grant usage on *.* to 'shane'@'127.0.0.1' identified by '12345';
exit
mysql -ushane -h127.0.0.1 -p12345 test

select user(),current_user();
show grants;

drop table if exists innodb_monitor;
create table innodb_monitor(a int)engine=innodb;
#look in error log
select sleep(30);
drop table if exists innodb_monitor;

drop table if exists innodb_table_monitor;
create table innodb_table_monitor(a int)engine=innodb;
#look in error log
select sleep(30);
drop table if exists innodb_table_monitor;

drop table if exists innodb_tablespace_monitor;
create table innodb_tablespace_monitor(a int)engine=innodb;
#look in error log
select sleep(30);
drop table if exists innodb_tablespace_monitor;

drop table if exists innodb_lock_monitor;
create table innodb_lock_monitor(a int)engine=innodb;
#look in error log
select sleep(30);
drop table if exists innodb_lock_monitor;

Suggested fix:
Since logging can have a negative performance impact, and potentially fill the disk, it
should be reserved for users with more privileges ?
[25 Jan 2008 15:01] Heikki Tuuri 
Vasil, please look at fixing this in 5.1.

The performance impact of InnoDB monitors is small, but they could fill the disk with the
.err log.

Regards,

Heikki
[26 Jan 2008 14:00] Miguel Solorzano 
Thank you for the bug report. Verified as described.
[11 Feb 2008 11:14] Vasil Dimov 
Patch that fixes this bug (against 5.1)

Attachment: bug34053.diff (application/octet-stream, text), 9.59 KiB.
[21 Feb 2008 0:48] Timothy Smith 
Queued in 5.1-build.  NOT applied to 6.0, yet.  Docs team, please return it to "Patch
approved", waiting for a 6.0 snapshot from InnoDB devs.
[22 Feb 2008 23:30] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42887

ChangeSet@1.2541, 2008-02-22 15:29:52-07:00, tsmith@ramayana.hindu.god +2 -0
  Bug #34053: normal users can enable innodb_monitor logging
  
  The check_global_access() function was made available to InnoDB, but
  was not defined in the embedded server library.  InnoDB, as a plugin,
  is not recompiled when the embedded server is built.  This caused a
  link failure when compiling applications which use the embedded server.
  
  The fix here is to always define check_global_access() externally; in
  the embedded server case, it is defined to just return OK.
[23 Feb 2008 0:56] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42891

ChangeSet@1.2541, 2008-02-22 16:56:34-07:00, tsmith@ramayana.hindu.god +3 -0
  Bug #34053: normal users can enable innodb_monitor logging
  
  The check_global_access() function was made available to InnoDB, but
  was not defined in the embedded server library.  InnoDB, as a plugin,
  is not recompiled when the embedded server is built.  This caused a
  link failure when compiling applications which use the embedded server.
  
  The fix here is to always define check_global_access() externally; in
  the embedded server case, it is defined to just return OK.
  
  Also, don't run the test case for this bug in embedded server.
[25 Feb 2008 16:59] Bugs System 
Pushed into 5.1.24-rc
[25 Feb 2008 17:05] Bugs System 
Pushed into 6.0.5-alpha
[25 Feb 2008 20:25] Timothy Smith 
Docs team: fixed in 5.1, but not yet in 6.0 (waiting for 6.0 snapshot).

Other minor detail: the check_global_access() function is made visible to
InnoDB in 6.0; but the changes in the handler code itself, to use that
function, are in 5.1 only.
[19 Mar 2008 0:47] Timothy Smith 
After this fix, PROCESS privilege is required to start/stop the InnoDB monitoring.
[2 Apr 2008 19:59] Jon Stephens 
Pushed into 5.1.23-ndb-6.3.11.
[17 Apr 2008 19:05] Paul DuBois 
Noted in 5.1.24, 6.0.5 changelogs.

The PROCESS privilege now is required to start or stop InnoDB
monitoring. Previously, no privilege was required.