Bug #26837 Return value ignored for packet->append() call within Log_event::read_log_event
Submitted: 5 Mar 2007 14:23 Modified: 7 Apr 2007 21:07
Reporter: Mark Leith
Status: Closed
Category:Server: Replication Severity:S3 (Non-critical)
Version:All OS:Any (All)
Assigned to: Magnus Blaudd Target Version:
Tags: bfsm_2007_03_15

[5 Mar 2007 14:23] Mark Leith 
Description:
The return value for a packet->append() call within Log_event::read_log_event is ignored,
in log_event.cc:667:

  packet->append(buf, sizeof(buf));

We should be checking the return on this, in case of memory allocation failures. 

How to repeat:
N/A
[23 Mar 2007 19:00] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/22818

ChangeSet@1.2415, 2007-03-23 19:00:34+01:00, msvensson@pilot.blaudden +1 -0
  Bug#26837 Return value ignored for packet->append() call within
Log_event::read_log_event
   - Improve error handling for "out of memory" problems when master is
     sending logs to slave. If memory allocation fails the log should
     now  report error "memory allocation failed reading log event"
[6 Apr 2007 19:21] Bugs System 
Pushed into 5.0.40
[6 Apr 2007 19:25] Bugs System 
Pushed into 5.1.18-beta
[7 Apr 2007 21:07] Paul DuBois 
Noted in 5.0.40, 5.1.18 changelogs.

Improved out-of-memory detection when sending logs from a master
server to slaves, and log a message when allocation fails.