Bug #20739 NT define not properly defined
Submitted: 27 Jun 2006 23:51 Modified: 3 Jul 2006 21:01
Reporter: Lars Thalmann
Status: Closed
Category:Server: Compiling Severity:S3 (Non-critical)
Version:5.0 OS:Microsoft Windows (Windows)
Assigned to: Bugs System Target Version:

[27 Jun 2006 23:51] Lars Thalmann 
Description:
We should perhaps not enable the __NT__ flag for all configurations. 
If necessary, that must only be done for configurations in -nt builds.
Otherwise we might break the 98/ME builds completely.

The __NT__ compile flag was introduced in the patch for BUG#19208.

How to repeat:
Check VC++Files/mysys/mysys.vcproj

Suggested fix:
Remove the flag somehow or be happy about it being there. :)
[28 Jun 2006 9:27] Kristian Nielsen 
I will add new project configurations "Release nt" and "Max nt" for mysys (and
additionally enable __NT__ in the Debug configuration).

I will then change mysql.sln so that the *nt solution configurations use "Release nt" and
"Max nt" for project mysys.
[28 Jun 2006 10:45] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/8382
[28 Jun 2006 11:18] Kristian Nielsen 
Pushed to mysql-5.0-rpl.
[28 Jun 2006 14:28] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/8404
[28 Jun 2006 15:18] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/8413
[29 Jun 2006 16:32] Lars Thalmann 
Pushed into release clone for 5.0.23 and into main 5.0 clone
[3 Jul 2006 21:01] Paul DuBois 
No changelog entry needed.