MySQL Bugs: #16935: can't build on Fedora Core Rawhide (FC5)

Bug #16935	can't build on Fedora Core Rawhide (FC5)
Submitted:	31 Jan 2006 13:57	Modified:	23 May 2006 17:21
Reporter:	Scott Douglass	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Query Browser	Severity:	S2 (Serious)
Version:	1.1.18	OS:	Linux (Fedora Core Rawhide)
Assigned to:	Alfredo Kojima	CPU Architecture:	Any

Description:
scott @ satellite > ./configure --with-gtkhtml=libgtkhtml-3.8
...
config.status: executing default-1 commands
scott @ satellite > make
Making all in library
make[1]: Entering directory `/home/scott/Desktop/mysql-query-browser-1.1.18/mysql-query-browser/library'
Making all in source
...
make[3]: Entering directory `/home/scott/Desktop/mysql-query-browser-1.1.18/mysql-query-browser/source/linux'
if g++ -DHAVE_CONFIG_H -I. -I. -I. -pthread -DORBIT2=1 -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgtkhtml-3.8 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnomeprintui-2.2 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libgnomeprint-2.2 -I/usr/include/gtkmm-2.4 -I/usr/lib/gtkmm-2.4/include -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/gdkmm-2.4 -I/usr/lib/gdkmm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/include/atkmm-1.6 -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include   -I/usr/include/mysql -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fwrapv -I../../../mysql-gui-common/source/linux -I../../../mysql-gui-common/library/include -I../../../mysql-gui-common/library_util/shared_include -I../../../mysql-gui-common/library_util/include -I../../library/include -I../../source/linux/gtksourceview -DPREFIX=\"""\" -DDATADIRNAME=\""share"\" -DCOMMONDIRNAME=\""common"\"    -g -O2 -MT main.o -MD -MP -MF ".deps/main.Tpo" -c -o main.o main.cc; \
then mv -f ".deps/main.Tpo" ".deps/main.Po"; else rm -f ".deps/main.Tpo"; exit 1; fi
../../../mysql-gui-common/source/linux/MGPreferences.h:43: error: extra qualification ‘MGOptions::’ on member ‘find_values’
make[3]: *** [main.o] Error 1
make[3]: Leaving directory `/home/scott/Desktop/mysql-query-browser-1.1.18/mysql-query-browser/source/linux'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/scott/Desktop/mysql-query-browser-1.1.18/mysql-query-browser/source/linux'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/scott/Desktop/mysql-query-browser-1.1.18/mysql-query-browser/source'
make: *** [all-recursive] Error 1

How to repeat:
./configure && make

Suggested fix:
No idea. Too bad I got addicted to this query browser! Back to the command line for me.

Looking at the source, the extra qualification isn't needed (as it's already in the aforementioned class) 

I guess the Fedora 5 compilers are a later, no-nonsense stricter version that doesn't like the otherwise harmless extras.

There's one more in the gui-common under MCrontab.h.

Removing both allows a successful compile but on my x86_64 platform, the resulting binary just segfaults (as does the downloadable)

If I get time later, I'll debug further.

The segfault looks like the result of someones "hack" at some point...

Looking in MQBookmarkBrowser.cc, line 260 theres a 

_menu.items()[3].set_sensitive(true); // New Folder 

My bet is that item 3 doesnt exist or isnt initialised or whatever hence the segfault. I just commented it out and I have a working query browser. 

Not sure where to submit patches so I'm just going to attach it to this bug. The patch fixes the above and also the segfaulting binary.

Apply with "patch -p1"

Hope that's of some use to y'all!

Bloody security: "Only registered developers and the original submitter are allowed to attach files to the bug."

Get the patch here: http://www.paulbanks.org.uk/patches/mysqlquerybrowser.fc5.1.patch

Cheers!

Paul Banks

Patch file

Attachment: mysqlquerybrowser.fc5.1.patch (application/octet-stream, text), 2.11 KiB.

Bug: http://bugs.mysql.com/bug.php?id=18512 was marked as
duplicate of this one.

Thank you for your bug report. This issue has been committed to our
source repository of that product and will be incorporated into the
next release.

If necessary, you can access the source repository and build the latest
available version, including the bugfix, yourself. More information 
about accessing the source trees is available at
    http://www.mysql.com/doc/en/Installing_source_tree.html