Bug #14090 The server stores junk in the TRG/TRN files

Description:
The MySQL server writes junk data in the names of the following attributes:
  - trigger parameters file (TRG), attribute "sql_mode":
    - string "sql_modes" is written with length 13 instead of 9;
  - in the trigger namespace file (TRN), attribute "trigger_table":
    - string "trigger_table" is written with length 15 instead of 13.

This happens because of the wrong definitions of File_option arrays
in sql/sql_trigger.cc:
  ...
  { (char *) "sql_modes", 13 },
  offsetof(class Table_triggers_list, definition_modes_list),
  FILE_OPTIONS_ULLLIST
  ...
  { (char *) "trigger_table", 15 },
  offsetof(struct st_trigname, trigger_table),
 FILE_OPTIONS_ESTRING

The problem is that fix of this bug breaks backward compatibility -- a database should be upgraded.

How to repeat:
Create a trigger, look into the corresponding TRG/TRN files.

Suggested fix:
Use STRING_WITH_LEN macro to define attribute names.

Just to note, it appears this is a problem when  mysql responds with:

  Unexpected end of file while skipping unknown parameter 'sql_modes'

With mysqld shutdown removing these files and re-creating the the trigger definitions, will solve the issue.  This has only happened when moving from 5.0.13 to 5.0.15 as far as I know.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/32178

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/32204

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/32271

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/32275

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/32441

Thank you for bugreport! Bug is fixed and pushed to 5.0.17 repository.

Server understand wrong .TRGs, but it takes a bit more time, so better recreate triggers created in old versions.

Noted in 5.0.17 changelog.

This happened to me when upgrading from 5.0.15 to 5.0.16. Stopping MySQL, nuking the *.TRN and *.TRG files, starting MySQL, and re-creating the triggers solved the problem for me too.