Bug #117562 Typo in sql/field.cc:301

• Submitted: 25 Feb 3:09
• Modified: 25 Feb 5:52
• Reporter: John Jove
• Status: Verified
• Category: MySQL Server: Data Types
• Severity: S3 (Non-critical)
• Version: 8.4.4
• OS: Any
• CPU Architecture: Any

[25 Feb 3:09] John Jove

Description:
I download the source code of MySQL Community Server 8.4.4 LTS
 from the official link https://dev.mysql.com/downloads/mysql/.
The md5 sum of the file is 8a84adf49a62da3147998928056d880b.

The comment of the field_types_merge_rules array contains a typo in Line 301, which should be MYSQL_TYPE_JSON, instead of MYSQL_TYPE_TINY.

How to repeat:
Download the source code of  MySQL Community Server 8.4.4 LTS and then check the file sql/field.cc in Line 301, in which the comment of the field_types_merge_rules array contains a typo.

301: // MYSQL_TYPE_BOOL         MYSQL_TYPE_TINY
302: MYSQL_TYPE_TINY, MYSQL_TYPE_VARCHAR,

should be

301: // MYSQL_TYPE_BOOL         MYSQL_TYPE_JSON
302: MYSQL_TYPE_TINY, MYSQL_TYPE_VARCHAR,

Suggested fix:
Change the comment MYSQL_TYPE_TINY in Line 301 into MYSQL_TYPE_JSON

[25 Feb 5:52] MySQL Verification Team

Hello John Jove,

Thank you for the report and feedback.
I think this issue was handled in 9.2 as part of your earlier filed Bug #116415

https://github.com/mysql/mysql-server/commit/3e2d13c272918292253af9ad7652d2150cd31f4b#diff...

This change was not taken place in 8.4 - https://github.com/mysql/mysql-server/blame/8.4/sql/field.cc#L301

regards,
Umesh