Bug #9472 --max-allowed-packet and --net-buffer-length don't handle K, M, G suffixes

• Submitted: 30 Mar 2005 4:33
• Modified: 7 Apr 2005 4:34
• Reporter: Jim Winstead
• Status: Closed
• Category: libmysqld
• Severity: S3 (Non-critical)
• Version: 4.1
• Assigned to: Jim Winstead

[30 Mar 2005 4:33] Jim Winstead

Description:
in get_one_option() in sql/mysqld.cc, there code to handle max-allowed-packet and
net-buffer-length for EMBEDDED_LIBRARY, but it uses atoi() and not something that knows
how to deal with the K, M, and G suffixes for sizes. this is why the myisam-blob test does
not work with the embedded server.

How to repeat:
disable the automatic skipping of myisam-blob in mysql-test-run when running with
--embedded-server, and run the myisam-blob test. notice the error messages say "Result of
repeat() was larger than max_allowed_packet (24) - truncated"

Suggested fix:
eval_num_suffix() in mysys/my_getopt.c has the code to handle these suffixes, but it is
static to that file.

[31 Mar 2005 4:11] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/23516

[2 Apr 2005 2:07] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/internals/23574

[5 Apr 2005 22:04] Jim Winstead

Fixed in 4.1.12 and 5.0.4.

[7 Apr 2005 4:34] Paul DuBois

Noted in 4.1.12, 5.0.4 changelogs.