Bug #63130 CMake-based check for the presence of a system readline library is not reliable.

Description:
The MYSQL_FIND_SYSTEM_READLINE macro, which tests whether the Readline library is availability by trying to compile and link a test program, does not handle the case where the Readline library uses termcap functions, but does not link with the termcap or curses library itself.

Also, the History library is not properly detected/used. The <readline/history.h> file should be include in any file that uses the History library's features. It supplies extern declarations for all of the library's public functions and variables, and declares all of the public data structures.

How to repeat:
cmake . -DWITH_READLINE=OFF -DWITH_LIBEDIT=OFF

Use the curses library and history header.

Attachment: Bug-63130-CMake-based-check-for-the-presence-of-a-system-readline.patch (application/octet-stream, text), 3.98 KiB.

I'm the OpenBSD port/package maintainer and was just about to file a bug report when I noticed this one. I have a similar patch for fixing the issue with the libreadline test not using FIND_CURSES() first and then using ${CURSES_LIBRARY} when testing for the libreadline library.

and FYI this affects both 5.5, 5.6 and anything newer.

Fix mysql_embedded linking with libreadline

Attachment: patch-libmysqld_examples_CMakeLists_txt (application/octet-stream, text), 532 bytes.

The patch I added is also necessary to fix linking mysql_embedded in addition to the patch provided by Davi.

Oh sorry I see the diff I posted isn't necessary since the approach Davi took was a little different and overrided READLINE_LIBRARY.

Bug #68087 was marked as duplicate of this one.

Fix

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: Bug#63130-CMake-based-check-for-the-presence-of-a-sy.patch (application/octet-stream, text), 3.97 KiB.

Posted by developer:
 
readline is no longer used in MySQL.

"readline is no longer used in MySQL"... Does the patch work then?

EditLine makes me feel sick ...