Bug #59900 | Verion 5.1 exports symbols SQLInstallDriverEx and SQLInstallDriverExW | ||
---|---|---|---|
Submitted: | 2 Feb 2011 18:50 | Modified: | 12 Oct 2012 19:21 |
Reporter: | Alona Rossen | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Connector / ODBC | Severity: | S3 (Non-critical) |
Version: | 5.1.8 | OS: | Linux |
Assigned to: | Bogdan Degtyariov | CPU Architecture: | Any |
[2 Feb 2011 18:50]
Alona Rossen
[4 Feb 2011 12:23]
Bogdan Degtyariov
Alona, Thank you for your bug report. Setting it to verified. We need to check HAVE_SQLGETPRIVATEPROFILESTRINGW preprocessor def, which affects exporting SQLInstallDriverExW function
[8 Mar 2012 8:46]
Bogdan Degtyariov
bug fix
Attachment: bug59900.diff (application/octet-stream, text), 5.83 KiB.
[8 Mar 2012 9:15]
Bogdan Degtyariov
nm libmyodbc5.so | grep SQLInstallDriverEx displays the empty string now.
[12 Sep 2012 22:48]
Ram Bysani
Hello This is a very high priority for us. Could you please increase priority, and let us know in what version you plan to fix it? Regards Ram Bysani rbysani@informatica.com
[12 Sep 2012 23:02]
Ram Bysani
Please note that this issue is seen on all operating systems and not just Linux 64 bit.
[25 Sep 2012 13:05]
Bogdan Degtyariov
patch v2
Attachment: bug59900v2.diff (application/octet-stream, text), 9.18 KiB.
[25 Sep 2012 13:24]
Bogdan Degtyariov
SQLRemoveDriverW seems to be the matching pair for SQLInstallDriverExW and therefore must be removed too.
[25 Sep 2012 13:27]
Bogdan Degtyariov
patch v3
Attachment: bug59900v3.diff (application/octet-stream, text), 10.09 KiB.
[25 Sep 2012 17:17]
Lawrenty Novitsky
I approve v3 of the patch, but please remove windows line endings. And do you need +#ifdef HAVE_LPCWSTR +# define MyODBC_LPCWSTR LPCWSTR +#else +# define MyODBC_LPCWSTR LPWSTR +#endif in the header file? Cuz in my opinion it is not really needed outside odbcinstw.c
[26 Sep 2012 7:30]
Bogdan Degtyariov
I intended to remove #ifdef HAVE_LPCWSTR from odbcinstw.c because SQLInstallDriverExW/SQLRemoveDriverW have been removed from there as well. Making LPCWSTR declarations available in stringutil.h looked better to me, but I am not against putting it into myodbc3i.c where the only usage of LPCWSTR declarations is.
[26 Sep 2012 9:35]
Hemant Dangi
Agreed with patch and #ifdef HAVE_LPCWSTR can be moved to myodbc3i.c
[26 Sep 2012 11:00]
Bogdan Degtyariov
Pushed to 5.1.12 (revision 1069)
[12 Oct 2012 19:21]
John Russell
Added to changelog for 5.1.12: The symbols SQLInstallDriverEx, SQLInstallDriverExW, and SQLRemoveDriverW were exported, causing incompatibility with some commercial ODBC packages such as DataDirect ODBC, and making Connector/ODBC dependent on the unixODBC library libodbcinst.so.1. This issue was first observed in Connector/ODBC 5.1.8.