Bug #58948 Valgrind warning in do_handle_one_connection()

• Submitted: 15 Dec 2010 17:53
• Modified: 6 Jan 2011 1:20
• Reporter: Alexander Nozdrin
• Status: Closed
• Category: MySQL Server: General
• Severity: S1 (Critical)
• Version: 5.6, 5.5
• OS: Any
• Assigned to: Sergey Vojtovich
• CPU Architecture: Any
• Tags: pb2, test failure

[15 Dec 2010 17:53] Alexander Nozdrin

Description:
Hi Alik,

the problem is around incosistent handling of security_ctx::proxy_user
variable, which was added recently along with pluggable authentication.
It will take some time to provide a good fix. Please expect it on
friday.

Regards,
Sergey

On Wed, Dec 15, 2010 at 10:25:00AM +0300, Alexander Nozdrin wrote:
> > Hi Sergey,
> > 
> > it looks like your push 'sergey.vojtovich... 2010-12-14 15:43:24'
> > (WL#5571) introduced a new valgrind warning:
> > 
> > ==11396== Conditional jump or move depends on uninitialised value(s)
> > ==11396==    at 0x6B29E5: do_handle_one_connection(THD*)
> > (sql_connect.cc:735)
> > ==11396==    by 0x6B2D3C: handle_one_connection (sql_connect.cc:684)
> > ==11396==    by 0x92B7FB: pfs_spawn_thread (pfs.cc:1360)
> > ==11396==    by 0x4E2B73C: start_thread (in /lib64/libpthread-2.5.so)
> > ==11396==    by 0x59DBD1C: clone (in /lib64/libc-2.5.so)
> > 
> > 
> > That's exposed at least by the following tests:
> >   - federated.federated
> >   - main.plugin_auth
> >   - main.plugin_auth_qa_2
> >   - main.plugin_auth_qa_3
> >   - rpl_ssl1
> >   - sys_vars.secure_auth_func
> >   - main.grant
> >   - sys_vars.old_passwords_func
> >   - main.openssl_1
> >   - main.connect
> > 
> > Could you please fix?
> > 
> > Thanks!

How to repeat:
*

[17 Dec 2010 8:54] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/127142

3208 Sergey Vojtovich	2010-12-17
      BUG#58948 - Valgrind warning in do_handle_one_connection()
      
      Fixed that proxy_user may be used uninitialized.
     @ sql/sql_class.cc
        Fixed that proxy_user may be used uninitialized.

[22 Dec 2010 21:30] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101222212842-y0t3ibtd32wd9qaw) (version source revid:[e-mail]-20101222212842-y0t3ibtd32wd9qaw) (merge vers: 5.6.1) (pib:24)

[29 Dec 2010 12:53] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101229113652-km2v993aurv7h79j) (version source revid:[e-mail]-20101229113132-uonlbcc2uopff8yb) (merge vers: 5.5.9) (pib:24)

[6 Jan 2011 1:20] Paul DuBois

Noted in 5.5.9 changelog.

Several Valgrind warnings were fixed.