Bug #58915 | Valgrind warning in MYSQLparse() | ||
---|---|---|---|
Submitted: | 14 Dec 2010 10:01 | Modified: | 24 Mar 2011 22:31 |
Reporter: | Alexander Nozdrin | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: General | Severity: | S1 (Critical) |
Version: | 5.6 | OS: | Any |
Assigned to: | Magne Mæhre | CPU Architecture: | Any |
[14 Dec 2010 10:01]
Alexander Nozdrin
[19 Jan 2011 9:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/129151 3527 Magne Mahre 2011-01-19 Bug#58915 Valgrind warning in MYSQLparse() Under execution of a CHANGE MASTER command, a dynamic array (lex.bi.repl_ignore_server_ids) in the LEX replication information structure is allocated. Under normal operation, this array was deallocated at the end of execution (end of change_master() ). Certain error conditions (most notable if the client thread is killed) would abort the execution before change_master() is called, resulting in memory block being lost. The deallocation has been moved to THD::cleanup_after_query() to ensure that correct deallocation happens in all situations. @ sql/rpl_slave.cc Moved deallocation to THD::cleanup_after_query @ sql/sql_class.cc Moved cleanup code here (from change_master()) @ sql/sql_lex.cc Initialize replication information structure to a known (0) value.
[3 Feb 2011 10:13]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/130307 3596 Magne Mahre 2011-02-03 Bug#58915 Valgrind warning in MYSQLparse() Under execution of a CHANGE MASTER command, a dynamic array (lex.bi.repl_ignore_server_ids) in the LEX replication information structure is allocated. Under normal operation, this array was deallocated at the end of execution (end of change_master() ). Certain error conditions (most notable if the client thread is killed) would abort the execution before change_master() is called, resulting in memory block being lost. The deallocation has been moved to THD::cleanup_after_query() to ensure that correct deallocation happens in all situations. @ sql/rpl_slave.cc Moved deallocation to THD::cleanup_after_query @ sql/sql_class.cc Moved cleanup code here (from change_master()) @ sql/sql_lex.cc Initialize replication information structure to a known (0) value.
[3 Feb 2011 10:13]
Bugs System
Pushed into mysql-trunk 5.6.2 (revid:magne.mahre@oracle.com-20110203101306-q8auashb3d7icxho) (version source revid:magne.mahre@oracle.com-20110203101306-q8auashb3d7icxho) (merge vers: 5.6.2) (pib:24)
[24 Mar 2011 22:31]
Paul DuBois
Problem not present in any released version. No changelog entry needed. CHANGESET - http://lists.mysql.com/commits/130307