Bug #58511 mysqltest doesn't always run statements in ps mode
Submitted: 26 Nov 2010 7:56 Modified: 20 Dec 2010 3:08
Reporter: Daniel Fischer Email Updates:
Status: Closed Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:any, 5.0, 5.1, 5.6.1 OS:Any
Assigned to: Bjørn Munch CPU Architecture:Any

[26 Nov 2010 7:56] Daniel Fischer
Description:
From https://bugs.launchpad.net/mysql-server/+bug/676938

Mysqltest will not honour --ps-protocol for this query, and will execute it in text mode:
/* comment */ select * from t1;

How to repeat:
See description.
[27 Nov 2010 11:49] Sveta Smirnova
Thank you for the report.

Verified as described. It does not prepares same query without comment too:

select * from t1;
[29 Nov 2010 11:11] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/125319

2956 Bjorn Munch	2010-11-29
      Bug #58511 mysqltest doesn't always run statements in ps mode
      mysqltest checks if the stmt is one that should be run in ps mode,
       but regexp doesn't match if preceeded by /* */ comment.
      Fix: match function will jump over /*..*/ if found at start
[30 Nov 2010 9:25] Daniel Fischer
Patch looks like it would work.

Does this accidentally fix a similar bug with views?
[9 Dec 2010 13:44] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/126423

2959 Bjorn Munch	2010-12-09
      Bug #58511 mysqltest doesn't always run statements in ps mode
      mysqltest checks if the stmt is one that should be run in ps mode,
        but regexp doesn't match if preceeded by /* */ comment.
      Fix: match function will jump over /*..*/ if found at start
[9 Dec 2010 16:22] Bjørn Munch
Pushed to -mtr trees
[17 Dec 2010 12:48] Bugs System
Pushed into mysql-5.1 5.1.55 (revid:georgi.kodinov@oracle.com-20101217124435-9imm43geck5u55qw) (version source revid:bjorn.munch@oracle.com-20101209193247-7c4ob7wuy21clt42) (merge vers: 5.1.55) (pib:24)
[17 Dec 2010 12:51] Bugs System
Pushed into mysql-5.5 5.5.9 (revid:georgi.kodinov@oracle.com-20101217124733-p1ivu6higouawv8l) (version source revid:bjorn.munch@oracle.com-20101209195322-embe21sfutgb3oy0) (merge vers: 5.5.8) (pib:24)
[17 Dec 2010 12:55] Bugs System
Pushed into mysql-trunk 5.6.1 (revid:georgi.kodinov@oracle.com-20101217125013-y8pb3az32rtbplc9) (version source revid:anitha.gopi@sun.com-20101210041312-50t9adyhwwybsm6x) (merge vers: 5.6.1) (pib:24)
[20 Dec 2010 3:08] Paul DuBois
Changes to test suite. No changelog entry needed.