Bug #58424 | mtr ignores failing mysqltest in the presence of expect file for mysqld | ||
---|---|---|---|
Submitted: | 23 Nov 2010 18:20 | Modified: | 20 Dec 2010 3:08 |
Reporter: | Luis Soares | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Tools: MTR / mysql-test-run | Severity: | S3 (Non-critical) |
Version: | 5.5 | OS: | Any |
Assigned to: | Bjørn Munch | CPU Architecture: | Any |
[23 Nov 2010 18:20]
Luis Soares
[23 Nov 2010 19:00]
Bjørn Munch
I was able to reproduce the problem running binlog.binlog_index. What actually happens in this test is that one of the "purge" commands succeeds in stead of failing with error 2013. And then mtr picks up the crashed mysqltest *before* it sees mysqld. With verbose logging, we see: --- worker[1] > Started [mysqld.1 - pid: 11319, winpid: 11319] worker[1] > Got [mysqltest - pid: 11303, winpid: 11303, exit: 256] worker[1] > Crash was expected, file '/export/home/tmp/bm/mysql-5.5.8-solaris10-i386/mysql-test/var/tmp/mysqld.1.expect' exists --- Oops! It restarts mysqld and that seems to work since the previous mysqld has now also died. But then mtr has probably forgotten that mysqltest has died and waits for it until timeout. So the test *should* have failed: --- mysqltest: At line 130: query 'purge binary logs TO 'master-bin.000006'' succeeded - should have failed with errno 2013... --- (It varies from run to run which one failes)
[24 Nov 2010 9:24]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/124817 2952 Bjorn Munch 2010-11-24 Bug #58424 mtr ignores failing mysqltest in the presence of expect file for mysqld If mysqltest dies, mtr waits to see if mysqld dies too within 100ms But in that case, it should not care about expected crash Fix: jump past the code that checks the expect file
[27 Nov 2010 16:51]
Paul DuBois
Changes to test suite. No changelog entry needed.
[5 Dec 2010 12:38]
Bugs System
Pushed into mysql-trunk 5.6.1 (revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (version source revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)
[16 Dec 2010 22:26]
Bugs System
Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)
[17 Dec 2010 12:49]
Bugs System
Pushed into mysql-5.1 5.1.55 (revid:georgi.kodinov@oracle.com-20101217124435-9imm43geck5u55qw) (version source revid:mats.kindahl@oracle.com-20101201193331-1c07sjno2g7m46ix) (merge vers: 5.1.55) (pib:24)