Bug #57996 Compiler flag change build error on OSX 10.5 : bind.c

• Submitted: 4 Nov 2010 19:55
• Modified: 11 Dec 2010 17:35
• Reporter: Karen Langford
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.1.53
• OS: MacOS (10.5)
• Assigned to: Davi Arnaut
• CPU Architecture: Any

[4 Nov 2010 19:55] Karen Langford

Description:
Compiler flag change causing build failure on:
slid11.norway.sun.com / osx10.5-x86 / i386-apple-darwin9.8.0
slid12.norway.sun.com / osx10.5-x86_64 / i386-apple-darwin9.8.0

gcc -static-libgcc -DMYSQL_CLIENT_NO_THREADS -DHAVE_CONFIG_H -DNO_KILL_INTR -D_GNU_SOURCE=1 -I. -I../../include -I../../include -I../../include -I../..   -Wall -Wextra -Wunused -Wwrite-strings -Wno-strict-aliasing -Werror -g  -DSAFE_MUTEX -g -O -arch i386 -fno-common   -D_P1003_1B_VISIBLE -DSIGNAL_WITH_VIO_CLOSE -DSIGNALS_DONT_BREAK_READ -DIGNORE_SIGHUP_SIGQUIT  -DDONT_DECLARE_CXA_PURE_VIRTUAL -MT bind.o -MD -MP -MF .deps/bind.Tpo -c -o bind.o bind.c
cc1: warnings being treated as errors
bind.c: In function '_rl_read_init_file':
bind.c:858: warning: 'file_size' may be used uninitialized in this function
make[2]: *** [bind.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

How to repeat:
Build 5.1.53 without flag --enable-mysql-maintainer-mode=no

[10 Nov 2010 21:15] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123501

3503 Davi Arnaut	2010-11-10
      Bug#58057: 5.1 libmysql/libmysql.c unused variable/compile failure
      Bug#57995: Compiler flag change build error on OSX 10.4: my_getncpus.c
      Bug#57996: Compiler flag change build error on OSX 10.5 : bind.c
      Bug#57994: Compiler flag change build error : my_redel.c
      Bug#57993: Compiler flag change build error on FreeBsd 7.0 : regexec.c
      Bug#57992: Compiler flag change build error on FreeBsd : mf_keycache.c
      Bug#57997: Compiler flag change build error on OSX 10.6: debug_sync.cc
      
      Fix assorted compiler generated warnings.
     @ cmd-line-utils/readline/bind.c
        Bug#57996: Compiler flag change build error on OSX 10.5 : bind.c
        
        Initialize variable to work around a false positive warning.
     @ include/m_string.h
        Bug#57994: Compiler flag change build error : my_redel.c
        
        The expansion of stpcpy (in glibc) causes warnings if the
        return value of strmov is not being used. Since stpcpy is
        a GNU extension and the expansion ends up using a built-in
        provided by GCC, use the compiler provided built-in directly
        when possible.
     @ include/my_compiler.h
        Define a dummy MY_GNUC_PREREQ when not compiling with GCC.
     @ libmysql/libmysql.c
        Bug#58057: 5.1 libmysql/libmysql.c unused variable/compile failure
        
        Variable might not be used in some cases. So, tag it as unused.
     @ mysys/mf_keycache.c
        Bug#57992: Compiler flag change build error on FreeBsd : mf_keycache.c
        
        Use UNINIT_VAR to work around a false positive warning.
     @ mysys/my_getncpus.c
        Bug#57995: Compiler flag change build error on OSX 10.4: my_getncpus.c
        
        Declare variable in the same block where it is used.
     @ regex/regexec.c
        Bug#57993: Compiler flag change build error on FreeBsd 7.0 : regexec.c
        
        Work around a compiler bug which causes the cast to not be enforced.
     @ sql/debug_sync.cc
        Bug#57997: Compiler flag change build error on OSX 10.6: debug_sync.cc
        
        Use UNINIT_VAR to work around a false positive warning.
     @ sql/handler.cc
        Use UNINIT_VAR to work around a false positive warning.
     @ sql/slave.cc
        Use UNINIT_VAR to work around a false positive warning.
     @ sql/sql_partition.cc
        Use UNINIT_VAR to work around a false positive warning.
     @ storage/myisam/ft_nlq_search.c
        Use UNINIT_VAR to work around a false positive warning.
     @ storage/myisam/mi_create.c
        Use UNINIT_VAR to work around a false positive warning.
     @ storage/myisammrg/myrg_open.c
        Use UNINIT_VAR to work around a false positive warning.
     @ tests/mysql_client_test.c
        Change function to take a pointer to const, no need for a cast.

[12 Nov 2010 14:32] Jon Olav Hauglid

Ok to push.

[16 Nov 2010 9:46] Davi Arnaut

Pushed into mysql-5.1-bugteam and up.

[20 Nov 2010 0:49] Paul DuBois

Noted in 5.1.54, 5.5.8 changelogs.

Several compilation problems were fixed.

[5 Dec 2010 12:40] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[15 Dec 2010 5:52] Bugs System

Pushed into mysql-5.1 5.1.55 (revid:[e-mail]-20101215054055-vgwki317xg1wphhh) (version source revid:[e-mail]-20101215054055-vgwki317xg1wphhh) (merge vers: 5.1.55) (pib:23)

[16 Dec 2010 22:29] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (version source revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)