Bug #57604 Reserve bit in option_bits for slave_allow_batching feature

• Submitted: 20 Oct 2010 13:41
• Modified: 6 Jan 2011 15:06
• Reporter: Magnus Blåudd
• Status: Closed
• Category: MySQL Server
• Severity: S2 (Serious)
• Version: 5.5.7-rc
• OS: Any
• Assigned to: Magnus Blåudd
• CPU Architecture: Any
• Tags: SEAGULL

[20 Oct 2010 13:41] Magnus Blåudd

Description:
To prevent that BUG#57603 happens again we need to reserve a bit in option_bits for the slave_allow_batching feature that currently only exist in MySQL Cluster.

How to repeat:
See BUG#57603

Suggested fix:
=== modified file 'sql/sql_priv.h'
--- sql/sql_priv.h	2010-08-05 12:53:09 +0000
+++ sql/sql_priv.h	2010-10-20 13:41:22 +0000
@@ -144,6 +144,11 @@
 */
 #define OPTION_MASTER_SQL_ERROR (1ULL << 35)
 
+/*
+  Dont report errors for individual rows,
+  But just report error on commit (or read ofcourse)
+*/
+#define OPTION_ALLOW_BATCH              (ULL(1) << 36) // THD, intern (slave)
 
 /* The rest of the file is included in the server only */
 #ifndef MYSQL_CLIENT

[20 Oct 2010 13:45] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121332

[20 Oct 2010 13:56] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121336

[5 Dec 2010 12:38] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[11 Dec 2010 17:16] Paul DuBois

Bug does not appear in any released 5.6.x version.

Setting report to Need Merge pending push to 5.5.x.

[17 Dec 2010 12:54] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101217124733-p1ivu6higouawv8l) (version source revid:[e-mail]-20101125051437-3pavhs14p7zhks0c) (merge vers: 5.5.8) (pib:24)

[6 Jan 2011 15:06] Paul DuBois

Noted in 5.5.9 changelog.

sql_priv.h now includes an OPTION_ALLOW_BATCH flag for the
transaction_allow_batching feature of MySQL Cluster.