Bug #56654 | pb2 log is very hard to read | ||
---|---|---|---|
Submitted: | 8 Sep 2010 13:56 | Modified: | 14 Nov 2010 2:53 |
Reporter: | Sven Sandberg | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Tools: MTR / mysql-test-run | Severity: | S7 (Test Cases) |
Version: | 5.1 | OS: | Any |
Assigned to: | Bjørn Munch | CPU Architecture: | Any |
Tags: | mtr, mysqltest, pb2 |
[8 Sep 2010 13:56]
Sven Sandberg
[8 Sep 2010 13:57]
Sven Sandberg
See also BUG#56648.
[8 Sep 2010 14:19]
Bjørn Munch
What caused all these failures would be Bug #56528 which causes memory to fill up. 1. When memory fills up, bad things happen, mtr cannot be expected to fully analyze the cause but will report the symptom. 2. Error messages relating to a test will refer to the last test mentioned in the log. 3. OK some wrapper lines could probably be added to the server log output. 4. When we dump server log, we dump server log, mtr cannot possibly decide what to include and what not to. 5. The code does but sometimes it still doesn't output, maybe due to resource constraints. Nothing we can do about that, apart from mentioning that it did produce no output. 6. OK can probably do that.
[8 Sep 2010 16:30]
Sven Sandberg
1. I think maybe you misunderstood my request. This is a log where developers expect to find information to debug their test cases or mysqld. If there are messages that indicate host problems, it would be good if those messages were clearly marked as such. For example, we could print something like the following (assuming the file we are waiting for is supposed to be generated by mysqld): worker[2] mysql-test-run: WARNING: Waited X seconds for <FILE> to be created. I will wait for Y more seconds. (Explanation: mysql-test-run has started a mysqld process. Normally, the mysqld process creates this file soon after startup. Since mysql-test-run detected that the file is not yet created, it may indicate a host problem, perhaps out of memory or disk space. Beware that subsequent errors may also be due to a host problem.) 2. When running test case X, followed by test case Y, and check-testcase fails before test Y, it will print Y as a header and then an error message. But it is usually test X that caused a crash. This may lead to confusion. I'm only asking that we clarify the message and say that X is likely causing the problem. 3. Thank you! 4. OK, it wasn't clear to me that the valgrind version was part of the server log. I think it will be more clear after you implement 3. So nothing to do here. 5. Can we add something to guide the person who has to analyze the logs? For example, I think we could print something like this: mysql-test-run has detected that mysqltest failed without producing any output when executing the test <test name>. This is likely due to a host problem, maybe out of memory or disk space. Beware that subsequent errors may also be due to a host problem. 6. Thank you! :-)
[12 Oct 2010 13:32]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120546 2940 Bjorn Munch 2010-10-12 Bug #56654 pb2 log is very hard to read Added some more info in a number of fail cases
[13 Oct 2010 7:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120627 2941 Bjorn Munch 2010-10-13 [merge] Bug #56654 pb2 log is very hard to read Added some more info in a number of fail cases
[13 Oct 2010 11:10]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120669 2941 Bjorn Munch 2010-10-13 Bug #56654 pb2 log is very hard to read Added some more info in a number of fail cases
[19 Oct 2010 12:02]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/121126 2942 Bjorn Munch 2010-10-19 Bug #56654 pb2 log is very hard to read Added some more info in a number of fail cases (re-commit for administrative reasons)
[19 Oct 2010 13:10]
Bjørn Munch
Pushed to -mtr branches
[29 Oct 2010 15:29]
Paul DuBois
Changes to test suite. No changelog entry needed.
[13 Nov 2010 16:08]
Bugs System
Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113152450-2zzcm50e7i4j35v7) (merge vers: 5.6.1-m4) (pib:21)
[13 Nov 2010 16:39]
Bugs System
Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:vasil.dimov@oracle.com-20100629074804-359l9m9gniauxr94) (pib:21)
[18 Nov 2010 15:53]
Bugs System
Pushed into mysql-5.1 5.1.54 (revid:build@mysql.com-20101118153531-693taxtxyxpt037i) (version source revid:build@mysql.com-20101118153531-693taxtxyxpt037i) (merge vers: 5.1.54) (pib:21)
[16 Dec 2010 22:30]
Bugs System
Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)