Bug #54935 few tests with explicit log pos stand in the way wl#2540 merging
Submitted: 1 Jul 2010 15:56 Modified: 4 Aug 2010 15:38
Reporter: Andrei Elkin Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Replication Severity:S3 (Non-critical)
Version:5.1-rep+2, 5.5+ OS:Any
Assigned to: Andrei Elkin CPU Architecture:Any
Tags: replication tests

[1 Jul 2010 15:56] Andrei Elkin
Description:
Few tests in trunk, next-mr (atm) slipped to recieve bug#49741 fixes.
Explicit log positions in tests/results are intolerable for wl#2540. 

How to repeat:
cd next-mr/mysql-test && find . -name *.test -exec grep -Hn  -- '-position=[ 0-9]' {} \; | wc -l

=> 25

More explicitly:

find . -name *.test -exec grep -Hn  -- '-position=[ 0-9]' {} \; | head -n 3
./extra/binlog_tests/mix_innodb_myisam_binlog.test:337:  --exec $MYSQL_BINLOG --start-position=556 $MYSQLD_DATADIR/master-bin.000001 > $MYSQLTEST_VARDIR/tmp/mix_innodb_myisam_binlog.output
./t/mysqlbinlog.test:78:--exec $MYSQL_BINLOG --short-form --local-load=$MYSQLTEST_VARDIR/tmp/ --start-position=1074 $MYSQLD_DATADIR/master-bin.000002
./t/mysqlbinlog.test:114:--exec $MYSQL_BINLOG --short-form --local-load=$MYSQLTEST_VARDIR/tmp/ --read-from-remote-server --start-position=1074 --user=root --host=127.0.0.1 --port=$MASTER_MYPORT master-bin.000002

Suggested fix:
Apply the referred bug technique.
[9 Jul 2010 14:42] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113264

3302 Andrei Elkin	2010-07-09
      Bug #54935 few tests with explicit log pos stand in the way wl#2540 merging
      
      Few unnoticed or private to 5.5+ trees tests containing explicit binlog positions
      are fixed along in the wake of bug@49741.
      That includes:
      - identifying explicit positions and setting a let-variables to contain the value.
      - masking out explicit log position.
     @ mysql-test/extra/binlog_tests/binlog.test
        identifying explicit positions and setting a let-variables to contain the value.
     @ mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test
        identifying explicit positions and setting a let-variables to contain the value.
     @ mysql-test/extra/rpl_tests/rpl_conflicts.test
        masking out explicit log position.
     @ mysql-test/r/rpl_mysqldump_slave.result
        results changed as expected
     @ mysql-test/suite/binlog/r/binlog_row_binlog.result
        results changed as expected
     @ mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result
        results changed as expected
     @ mysql-test/suite/binlog/r/binlog_stm_binlog.result
        results changed as expected
     @ mysql-test/suite/binlog/t/binlog_killed_simulate.test
        identifying explicit positions and setting a let-variables to contain the value.
        masking out explicit log position.
     @ mysql-test/suite/rpl/r/rpl_row_conflicts.result
        results changed as expected
     @ mysql-test/suite/rpl/r/rpl_stm_conflicts.result
        results changed as expected
     @ mysql-test/suite/rpl/r/rpl_stm_until.result
        results changed as expected
     @ mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test
        identifying explicit positions and setting a let-variables to contain the value.
        masking out explicit log position.
     @ mysql-test/suite/rpl/t/rpl_stm_until.test
        masking out explicit log position.
     @ mysql-test/suite/rpl_ndb/r/rpl_ndb_multi.result
        results changed as expected
     @ mysql-test/suite/rpl_ndb/t/rpl_ndb_multi.test
        masking out explicit log position.
     @ mysql-test/t/mysqlbinlog.test
        identifying explicit positions and setting a let-variables to contain the value.
     @ mysql-test/t/mysqlbinlog2.test
        identifying explicit positions and setting a let-variables to contain the value.
     @ mysql-test/t/rpl_mysqldump_slave.test
        masking out explicit log position.
[15 Jul 2010 14:07] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113677

3303 Andrei Elkin	2010-07-15
       bug#54935 few tests with explicit log pos stand in the way wl#2540 merging
      
      adding comments to mix_innodb_myisam_binlog.test explaing why there is
      a wait call which looks unnessary. 
      Waiting is not supposed to cause any delay but it is good to have is a kind of assert of some expected property (presense of ROLLBACK in binlog in this case).
[15 Jul 2010 14:43] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113681

3303 Andrei Elkin	2010-07-15
       bug#54935 few tests with explicit log pos stand in the way wl#2540 merging
      
      Deploying an assert about expected ROLLBACK query instead of asking question wait_for macro
[16 Jul 2010 18:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113790

3057 Andrei Elkin	2010-07-16
      bug#54935
      
      applying bundle made for next-mr-bugfixing to trunk-bugfixing branch of the bug
[16 Jul 2010 18:26] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113791

3058 Andrei Elkin	2010-07-16
      bug#54935
      
      applying bundle made for next-mr-bugfixing to trunk-bugfixing branch of the bug
[17 Jul 2010 11:09] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113807

3126 Andrei Elkin	2010-07-17 [merge]
      merging for bug#54935 to trunk-bugfixing
[17 Jul 2010 12:02] Andrei Elkin
pushed to trunk- and next-mr- bugfixing.
[23 Jul 2010 12:25] Bugs System
Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100723121820-jryu2fuw3pc53q9w) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)
[23 Jul 2010 12:31] Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100723121929-90e9zemk3jkr2ocy) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (pib:18)
[4 Aug 2010 15:40] Jon Stephens
Changes affected testing only; no end-user changes to document.

Closed.