| Bug #54649 | Remove unused code in file repl_failsafe.cc | ||
|---|---|---|---|
| Submitted: | 21 Jun 2010 3:23 | Modified: | 15 Nov 2010 13:18 |
| Reporter: | Zhenxing He | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Replication | Severity: | S3 (Non-critical) |
| Version: | 5.6 | OS: | Any |
| Assigned to: | Zhenxing He | CPU Architecture: | Any |
| Tags: | refactoring | ||
[21 Jun 2010 3:23]
Zhenxing He
[21 Jun 2010 5:48]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111648 3036 He Zhenxing 2010-06-21 WL#5385 Refactoring: Split replication into libraries BUG#54649 Remove unused code in file repl_failsafe.cc Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. ****** WL#5385 Refactoring: Split replication into libraries Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. ****** WL#5385 Refactoring: Split replication into libraries Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. @ libmysqld/CMakeLists.txt Removed sql_repl.cc, added binlog.cc ****** Removed sql_repl.cc, added binlog.cc ****** Removed sql_repl.cc, added binlog.cc @ libmysqld/Makefile.am Add binlog.cc ****** Add binlog.cc ****** Add binlog.cc @ mysql-test/lib/v1/mysql-test-run.pl Remove code using --init-rpl-role, --rpl-recovery-rank ****** Remove code using --init-rpl-role, --rpl-recovery-rank ****** Remove code using --init-rpl-role, --rpl-recovery-rank @ mysql-test/suite/rpl/rpl_1slave_base.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix2.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv4_as_ipv6.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv6.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/my.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_2ch.cnf Remove unused --init-rpl-role ****** Remove unused --init-rpl-role ****** Remove unused --init-rpl-role @ sql/CMakeLists.txt Added replication libraries ****** Added replication libraries ****** Added replication libraries @ sql/Makefile.am Added replication libraries ****** Added replication libraries ****** Added replication libraries @ sql/binlog.cc Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc ****** Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc ****** Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc @ sql/binlog.h Moved binlog related code from log.h to binlog.h ****** Moved binlog related code from log.h to binlog.h ****** Moved binlog related code from log.h to binlog.h @ sql/log.cc Move binlog related code to binlog.cc ****** Move binlog related code to binlog.cc ****** Move binlog related code to binlog.cc @ sql/log.h Move binlog related code to binlog.cc ****** Move binlog related code to binlog.cc ****** Move binlog related code to binlog.cc @ sql/rpl_rli.cc added mysql_show_relaylog_events ****** added mysql_show_relaylog_events ****** added mysql_show_relaylog_events @ sql/rpl_rli.h moved some relay log related functions delaration here from slave.h ****** moved some relay log related functions delaration here from slave.h ****** moved some relay log related functions delaration here from slave.h @ sql/rpl_slave.cc Moved slave related code in sql_repl.cc here ****** Moved slave related code in sql_repl.cc here ****** Moved slave related code in sql_repl.cc here @ sql/rpl_slave.h moved slave related declarations from sql_repl.h ****** moved slave related declarations from sql_repl.h ****** moved slave related declarations from sql_repl.h @ sql/sql_class.cc Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h ****** Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h ****** Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h @ sql/sql_parse.cc use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command ****** use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command ****** use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command @ sql/sql_repl.cc Split sql_repl.cc into sql_master.cc and sql_slave.cc ****** Split sql_repl.cc into sql_master.cc and sql_slave.cc ****** Split sql_repl.cc into sql_master.cc and sql_slave.cc @ sql/sql_repl.h removed sql_repl.h, move code to slave.h and master.h correspondly ****** removed sql_repl.h, move code to slave.h and master.h correspondly ****** removed sql_repl.h, move code to slave.h and master.h correspondly @ sql/structs.h Moved definition of Discrete_intervals_list::append from sql_class.cc ****** Moved definition of Discrete_intervals_list::append from sql_class.cc ****** Moved definition of Discrete_intervals_list::append from sql_class.cc
[21 Jun 2010 5:56]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111649 3036 He Zhenxing 2010-06-21 WL#5385 Refactoring: Split replication into libraries BUG#54649 Remove unused code in file repl_failsafe.cc Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. @ libmysqld/CMakeLists.txt Removed sql_repl.cc, added binlog.cc @ libmysqld/Makefile.am Add binlog.cc @ mysql-test/lib/v1/mysql-test-run.pl Remove code using --init-rpl-role, --rpl-recovery-rank @ mysql-test/suite/rpl/rpl_1slave_base.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix2.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv4_as_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/my.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_2ch.cnf Remove unused --init-rpl-role @ sql/CMakeLists.txt Added replication libraries @ sql/Makefile.am Added replication libraries @ sql/binlog.cc Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc @ sql/binlog.h Moved binlog related code from log.h to binlog.h @ sql/log.cc Move binlog related code to binlog.cc @ sql/log.h Move binlog related code to binlog.cc @ sql/mysqld.cc removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/mysqld.h removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/rpl_rli.cc added mysql_show_relaylog_events @ sql/rpl_rli.h moved some relay log related functions delaration here from slave.h @ sql/rpl_slave.cc Moved slave related code in sql_repl.cc here renamed to rpl_slave.cc @ sql/rpl_slave.h moved slave related declarations from sql_repl.h renamed to rpl_slave.h @ sql/sql_class.cc Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h @ sql/sql_parse.cc use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command @ sql/sql_repl.cc Split sql_repl.cc into rpl_master.cc and rpl_slave.cc @ sql/sql_repl.h removed sql_repl.h, move code to rpl_slave.h and rpl_master.h correspondly @ sql/structs.h Moved definition of Discrete_intervals_list::append from sql_class.cc @ sql/sys_vars.cc Removed rpl_recovery_rank
[21 Jun 2010 10:35]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111675 2996 He Zhenxing 2010-06-21 WL#5385 Refactoring: Split replication into libraries BUG#54649 Remove unused code in file repl_failsafe.cc Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. @ libmysqld/CMakeLists.txt Removed sql_repl.cc, added binlog.cc @ libmysqld/Makefile.am Add binlog.cc @ mysql-test/lib/v1/mysql-test-run.pl Remove code using --init-rpl-role, --rpl-recovery-rank @ mysql-test/suite/rpl/rpl_1slave_base.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix2.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv4_as_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/my.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_2ch.cnf Remove unused --init-rpl-role @ sql/CMakeLists.txt Added replication libraries @ sql/Makefile.am Added replication libraries @ sql/binlog.cc Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc @ sql/binlog.h Moved binlog related code from log.h to binlog.h @ sql/log.cc Move binlog related code to binlog.cc @ sql/log.h Move binlog related code to binlog.cc @ sql/mysqld.cc removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/mysqld.h removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/rpl_rli.cc added mysql_show_relaylog_events @ sql/rpl_rli.h moved some relay log related functions delaration here from slave.h @ sql/rpl_slave.cc Moved slave related code in sql_repl.cc here renamed to rpl_slave.cc @ sql/rpl_slave.h moved slave related declarations from sql_repl.h renamed to rpl_slave.h @ sql/sql_class.cc Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h @ sql/sql_parse.cc use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command @ sql/sql_repl.cc Split sql_repl.cc into rpl_master.cc and rpl_slave.cc @ sql/sql_repl.h removed sql_repl.h, move code to rpl_slave.h and rpl_master.h correspondly @ sql/structs.h Moved definition of Discrete_intervals_list::append from sql_class.cc @ sql/sys_vars.cc Removed rpl_recovery_rank
[22 Jun 2010 3:11]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111728 2996 He Zhenxing 2010-06-22 WL#5385 Refactoring: Split replication into libraries BUG#54649 Remove unused code in file repl_failsafe.cc Splitting replication code into libraries for binlog, rpl, slave and master. - add binlog.[cc|h], moved BINLOG code from log.cc to binlog.[cc|h] - renamed slave.* to rpl_slave.* - split sql_repl.cc into rpl_master.cc and rpl_slave.cc - modified Makefile.am/CMakeLists.txt to build the libraries - orgnized functions in binlog.cc - removed sql_repl.h, added rpl_master.h move code to rpl_slave.h and rpl_master.h correspondly - split mysql_show_binlog_events, add mysql_show_relaylog_events and show_binlog_events. - removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, moved options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status. @ libmysqld/CMakeLists.txt Removed sql_repl.cc, added binlog.cc @ libmysqld/Makefile.am Add binlog.cc @ mysql-test/lib/v1/mysql-test-run.pl Remove code using --init-rpl-role, --rpl-recovery-rank @ mysql-test/suite/rpl/rpl_1slave_base.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ip_mix2.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv4_as_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl/t/rpl_ipv6.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/my.cnf Remove unused --init-rpl-role @ mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_2ch.cnf Remove unused --init-rpl-role @ sql/CMakeLists.txt Added replication libraries @ sql/Makefile.am Added replication libraries @ sql/binlog.cc Moved binlog related code from log.cc to binlog.cc Moved binlog related code from sql_class.cc to binlog.cc @ sql/binlog.h Moved binlog related code from log.h to binlog.h @ sql/log.cc Move binlog related code to binlog.cc @ sql/log.h Move binlog related code to binlog.cc @ sql/mysqld.cc removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/mysqld.h removed --init-rpl-role --rpl-recovery-rank and Rpl_status @ sql/rpl_rli.cc added mysql_show_relaylog_events @ sql/rpl_rli.h moved some relay log related functions delaration here from slave.h @ sql/rpl_slave.cc Moved slave related code in sql_repl.cc here renamed to rpl_slave.cc @ sql/rpl_slave.h moved slave related declarations from sql_repl.h renamed to rpl_slave.h @ sql/sql_class.cc Moved binlog related code to binlog.cc Moved definition of Discrete_intervals_list::append to structs.h @ sql/sql_parse.cc use mysql_show_relaylog_events for SHOW RELAYLOG EVENTS command @ sql/sql_repl.cc Split sql_repl.cc into rpl_master.cc and rpl_slave.cc @ sql/sql_repl.h removed sql_repl.h, move code to rpl_slave.h and rpl_master.h correspondly @ sql/structs.h Moved definition of Discrete_intervals_list::append from sql_class.cc @ sql/sys_vars.cc Removed rpl_recovery_rank
[22 Jun 2010 7:31]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111731 2997 He Zhenxing 2010-06-22 BUG#54649 Remove unused code in file repl_failsafe.cc Removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, removed options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status.
[23 Jun 2010 5:51]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111852 3000 He Zhenxing 2010-06-23 BUG#54649 Remove unused code in file repl_failsafe.cc Removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, removed options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status.
[24 Jun 2010 4:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/112011 3000 He Zhenxing 2010-06-24 BUG#54649 Remove unused code in file repl_failsafe.cc Removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, removed options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status.
[25 Jun 2010 3:06]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/112154 3001 He Zhenxing 2010-06-25 BUG#54649 Remove unused code in file repl_failsafe.cc Removed repl_failsafe.*, moved SHOW SLAVE HOSTS related code to rpl_master.cc, removed options --init-rpl-role, --rpl-recover-rank and status variable Rpl_status.
[19 Jul 2010 2:57]
Zhenxing He
Pushed to mysql-next-mr-rpl-merge
[23 Jul 2010 12:33]
Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100723121929-90e9zemk3jkr2ocy) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (pib:18)
[4 Aug 2010 8:07]
Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)
[4 Aug 2010 8:23]
Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)
[4 Aug 2010 13:22]
Jon Stephens
Documented in the 5.6.1 changelog as follows:
The unused and deprecated server options --init-rpl-role
and --rpl-recovery-rank, as well as the unused and
deprecated status variable Rpl_status, have been removed.
Closed.
[4 Aug 2010 13:59]
Jon Stephens
5.6 version is 5.6.0 not 5.6.1 - fixed changelog entry.
[10 Sep 2010 7:28]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/117960 3206 He Zhenxing 2010-09-10 Backport WL#5385 BUG#54649 to 5.5
[10 Sep 2010 7:39]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/117964 3206 He Zhenxing 2010-09-10 Backport WL#5385 BUG#54649 to 5.5
[13 Nov 2010 16:11]
Bugs System
Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (merge vers: 5.6.99-m5) (pib:21)
[13 Nov 2010 16:35]
Bugs System
Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:alexander.nozdrin@oracle.com-20101113152540-gxro4g0v29l27f5x) (pib:21)
[15 Nov 2010 13:18]
Jon Stephens
No new changelog entries required. Returned to Closed state.
[28 Nov 2010 10:00]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/125245 3148 He Zhenxing 2010-11-28 Backport WL#5385 BUG#54649 to 5.5
