Bug #53281 psi_abi_v1.h and psi_abi_v2.h should not be installed by CMAKE, no ABI check

• Submitted: 29 Apr 2010 7:54
• Modified: 4 Aug 2010 22:44
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: mysql-next-mr
• OS: Any
• Assigned to: Vladislav Vaintroub
• CPU Architecture: Any

[29 Apr 2010 7:54] Marc ALFF

Description:
When using CMAKE, the files
include/mysql/psi/psi_abi_v1.h
include/mysql/psi/psi_abi_v2.h

are installed in the target include directory.

These files are private, and should not be installed.

Also, the CMAKE build does not seem to perform ABI checks.

How to repeat:
make install

[29 Apr 2010 13:09] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/106942

3159 Vladislav Vaintroub	2010-04-29
      Bug#53281: extra headers installed.
      
      -add exclude pattern
      -also, allow abi_check to run on OSX in addition to Linux 
      (I still have reservations about compatibility of other Unixes diff
       and sed used in abi_check, so for now it will run only here)

[29 Apr 2010 14:42] Marc ALFF

Verified that the fix works for:
- OS: MacOSX 10.6.3
- gcc --version: i686-apple-darwin10-gcc-4.2.1

Patch approved.

Thanks for the fix,
-- Marc

[7 May 2010 9:21] Bugs System

Pushed into 6.0.14-alpha (revid:[e-mail]-20100507091908-vqyhpwf2km0aokno) (version source revid:[e-mail]-20100507091737-12vceffs11elb25g) (merge vers: 6.0.14-alpha) (pib:16)

[7 May 2010 9:23] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100507091823-nzao4h3qosau4tin) (version source revid:[e-mail]-20100507091720-ib9r8uny2aeazvas) (pib:16)

[8 May 2010 17:15] Paul DuBois

Noted in 6.0.14 changelog.

Internal Performance Schema header files were unnecessarily installed
publicly.

[4 Aug 2010 8:08] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:[e-mail]-20100507093958-2y0wy6svnc3zfgqb) (merge vers: 5.6.99-m4) (pib:18)

[4 Aug 2010 8:24] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:[e-mail]-20100507093958-2y0wy6svnc3zfgqb) (merge vers: 5.6.99-m4) (pib:18)

[4 Aug 2010 22:44] Paul DuBois

Bug does not appear in any released 5.6.x version.

[28 Apr 2011 15:35] Paul DuBois

Noted in 5.5.13 changelog.