Bug #52275 CMake configure wrapper does not handle --with-comment correctly

• Submitted: 22 Mar 2010 14:26
• Modified: 11 Dec 2010 17:30
• Reporter: Vladislav Vaintroub
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: mysql-next-mr
• OS: Any
• Assigned to: Vladislav Vaintroub
• CPU Architecture: Any

[22 Mar 2010 14:26] Vladislav Vaintroub

Description:
configure wrapper does not handle spaces in --with-comment properly.
Trying to use spaces results in "source directory does not exists"..
Also, wrapper uppercases the whole comment.

How to repeat:
vvaintroub@koala:~/bzr/bf$ BUILD/autorun.sh
...
vvaintroub@koala:~/bzr/bf$ ./configure "--with-comment=abc 123"
configure.pl : calling cmake /home/vvaintroub/bzr/bf  -DWITH_COMMENT=ABC 123=1
CMake Error: The source directory "/home/vvaintroub/bzr/bf/123=1" does not exist.

[22 Mar 2010 15:09] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/104011

3128 Vladislav Vaintroub	2010-03-22
      Bug #52275  	CMake configure wrapper does not handle --with-comment correctly
      
      Properly convert --with-comment
      do not uppercase it, quote as it might contain spaces.

[16 Jun 2010 12:37] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111263

3243 Vladislav Vaintroub	2010-06-16
      Bug #52275  	CMake configure wrapper does not handle --with-comment correctly
      
      Properly convert --with-comment
      do not uppercase it, quote as it might contain spaces.

[16 Jun 2010 12:39] Vladislav Vaintroub

queued to next-mr-bugfixing

[4 Aug 2010 8:03] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:[e-mail]-20100603095032-v5ptkkzt1bhz0m1d) (merge vers: 5.1.48) (pib:18)

[4 Aug 2010 8:19] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:[e-mail]-20100603095032-v5ptkkzt1bhz0m1d) (merge vers: 5.1.48) (pib:18)

[5 Aug 2010 9:40] MC Brown

Bug does not appear in any released version

[12 Nov 2010 1:18] Matt Blair

It appears that this patch needs to be applied to the 5.5 series as well.

[12 Nov 2010 1:34] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123676

3118 Vladislav Vaintroub	2010-11-12
      Bug #52275  CMake configure wrapper does not handle
      --with-comment correctly
            
      Properly convert --with-comment
      do not uppercase it, quote as it might contain spaces.

[12 Nov 2010 1:43] Vladislav Vaintroub

Done.
note that the future of the wrapper is not certain, we'd prefer people to use CMake-pure.

[5 Dec 2010 12:37] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[11 Dec 2010 17:30] Paul DuBois

Noted in 5.5.8 changelog.

The CMake "wrapper" for configure (configure.pl) did not handle the
--with-comment option properly.

[16 Dec 2010 22:25] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (version source revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)