Bug #51135 Please increase the maximum number of connections allowed in mysqltest

• Submitted: 12 Feb 2010 9:13
• Modified: 17 Jun 2010 19:28
• Reporter: Philip Stoev
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S7 (Test Cases)
• Version: next-mr
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[12 Feb 2010 9:13] Philip Stoev

Description:
The mysqltest binary has an internal hard-coded limit of 128 open connections. Unfortunately, in situations where we try to convert massive concurrent test runs into MTR test cases, it is possible to easily exceed that number.

Please increase the limit to 5120. I tried with 1024, and the binary compiled OK and worked as expected for my purposes.

How to repeat:
N/A

[16 Feb 2010 14:05] Bjørn Munch

Instead of increasing the hard-coded limit all the way up, I've coded an optional argument; default remains 128.  Do you have a concrete test case to try it with, or should I just construct something?

[17 Feb 2010 12:40] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/100627

2894 Bjorn Munch	2010-02-17
      Bug #51135 Please increase the maximum number of connections allowed in mysqltest
      Added --max-connections= argument to mysqltest and mtr

[17 Feb 2010 15:29] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/100641

2895 Bjorn Munch	2010-02-17
      Bug #51135 Please increase the maximum number of connections allowed in mysqltest
      Added --max-connections= argument to mysqltest and mtr
      Small fix to first patch: forgot to check before free'ing connections array

[17 Feb 2010 16:14] Magnus Blåudd

Looks fine

[18 Feb 2010 11:14] Bjørn Munch

Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr

[20 Feb 2010 9:31] Bugs System

Pushed into 6.0.14-alpha (revid:[e-mail]-20100220092844-jh07ayojyxn8uh9p) (version source revid:[e-mail]-20100218091145-31ydowr7lnkhkteq) (merge vers: 6.0.14-alpha) (pib:16)

[20 Feb 2010 9:34] Bugs System

Pushed into 5.5.3-m2 (revid:[e-mail]-20100220092622-wvhh1vfy5tjq4mhu) (version source revid:[e-mail]-20100218080238-5578xnc3hihr2muo) (merge vers: 5.5.3-m2) (pib:16)

[20 Feb 2010 9:36] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100220092730-paoo5t9gcajs5dq8) (version source revid:[e-mail]-20100218080908-zpakatqibw6vfud6) (pib:16)

[22 Feb 2010 20:15] Paul DuBois

Noted in 5.5.3, 6.0.14 changelogs.

mysqltest has a new --max-connections option to set a higher number 
of maximum allowed server connections than the default 128. This
option can also be passed via mysql-test-run.pl.

Setting report to Need Merge pending push into 5.1.x, Celosia.

[1 Mar 2010 8:45] Bugs System

Pushed into 5.1.45 (revid:[e-mail]-20100301083827-xnimmrjg6bh33o1o) (version source revid:[e-mail]-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)

[1 Mar 2010 16:30] Paul DuBois

Noted in 5.1.45 changelog.

[17 Jun 2010 12:06] Bugs System

Pushed into 5.1.47-ndb-7.0.16 (revid:[e-mail]-20100617114014-bva0dy24yyd67697) (version source revid:[e-mail]-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)

[17 Jun 2010 12:51] Bugs System

Pushed into 5.1.47-ndb-6.2.19 (revid:[e-mail]-20100617115448-idrbic6gbki37h1c) (version source revid:[e-mail]-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)

[17 Jun 2010 13:33] Bugs System

Pushed into 5.1.47-ndb-6.3.35 (revid:[e-mail]-20100617114611-61aqbb52j752y116) (version source revid:[e-mail]-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)