Bug #50942 mix_innodb_myisam_side_effects.test is not deterministic

• Submitted: 5 Feb 2010 12:39
• Modified: 14 Oct 2010 14:10
• Reporter: Andrei Elkin
• Status: Closed
• Category: Tests
• Severity: S3 (Non-critical)
• Version: 5.1+, !6.0-codebase-merge
• OS: Any
• Assigned to: Andrei Elkin
• CPU Architecture: Any
• Tags: non-deterministic test, test failure

[5 Feb 2010 12:39] Andrei Elkin

Description:
to allow failures like

http://pb2.norway.sun.com/web.py?template=mysql_show_test_failure&search=yes&push_id=92009...

-853,7 +853,7 @@
ERROR 23000: Duplicate entry '2' for key 'PRIMARY'
select count(*) from t1 /* must be 1 */;
count(*)
-1
+2

because of 

   UPDATE t3,t4 SET t3.a=t4.a + bug27417(1);

does not prescribe the order of two row operations implied by the update.

How to repeat:
See above.

Suggested fix:
To force the order with

UPDATE t3,t4 SET t3.a=t4.a + bug27417(1) WHERE t3.a=1;

which is okay as the failing snippet was designed to hit the dup key error
at the first row.

The where-clause fix has been pushed today to 6.0-codebase-merge.

[4 May 2010 19:32] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/107387

3367 Andrei Elkin	2010-05-04
      Bug #50942  	mix_innodb_myisam_side_effects.test is not deterministic 
      
      The test was used to fail because of 
       UPDATE t3,t4 SET t3.a=t4.a + bug27417(1);
      did not prescribe the order of two row operations implied by the update.
      
      Fixed with forcing the order with adding a where condition w/o
      affecting the former bug fixes logics.
     @ mysql-test/extra/binlog_tests/mix_innodb_myisam_side_effects.test
        implemented the bug page suggestion to make a test deterministic.
     @ mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result
        results are updated and (!) corrected.
     @ mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result
        results are updated

[16 May 2010 17:04] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108406

3385 Andrei Elkin	2010-05-16 [merge]
      pushing bug#50942 fixes to 5.1-bt

[16 May 2010 17:26] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108407

4073 Andrei Elkin	2010-05-16 [merge]
      null merge for bug#50942 fixes to pe tree

[18 May 2010 9:34] Andrei Elkin

pushed to 5.1-bt, pe trees.

[28 May 2010 6:11] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100524190136-egaq7e8zgkwb9aqi) (version source revid:[e-mail]-20100524190136-egaq7e8zgkwb9aqi) (pib:16)

[28 May 2010 6:39] Bugs System

Pushed into 6.0.14-alpha (revid:[e-mail]-20100524190941-nuudpx60if25wsvx) (version source revid:[e-mail]-20100524190409-5w4l7mje1wk1c90l) (merge vers: 6.0.14-alpha) (pib:16)

[28 May 2010 7:07] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100524185725-c8k5q7v60i5nix3t) (version source revid:[e-mail]-20100523204118-0tl3goawu658rxh6) (merge vers: 5.5.5-m3) (pib:16)

[28 May 2010 15:23] Paul DuBois

Changes to test case. No changelog entry needed.

[2 Jun 2010 8:50] Bugs System

Pushed into 5.1.48 (revid:[e-mail]-20100602084411-2yu607bslbmgufl3) (version source revid:[e-mail]-20100516170332-x8priwrdjwolc065) (merge vers: 5.1.47) (pib:16)

[14 Oct 2010 8:31] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:47] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 9:01] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 14:10] Jon Stephens

Setting back to Closed; see previous comments-